Skip to content

fix(taskbroker): Override Topic and Namespace in Task Sender Locally#117466

Merged
untitaker merged 3 commits into
masterfrom
george/fix/override-task-sender-locally
Jun 12, 2026
Merged

fix(taskbroker): Override Topic and Namespace in Task Sender Locally#117466
untitaker merged 3 commits into
masterfrom
george/fix/override-task-sender-locally

Conversation

@george-sentry

Copy link
Copy Markdown
Member

Before, when calling taskbroker-send-tasks with topic and namespace override, they would be set as global options. This breaks routing for other taskworkers using the same database. So let's override topic and namespace locally instead.

@george-sentry george-sentry requested a review from a team as a code owner June 11, 2026 20:27
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 11, 2026

@untitaker untitaker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can't work -- we need to have route overrides in options for inc response, just not set them globally from this one command.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 58905b5. Configure here.

Comment thread src/sentry/taskworker/adapters.py Outdated
@untitaker untitaker merged commit 562b553 into master Jun 12, 2026
85 checks passed
@untitaker untitaker deleted the george/fix/override-task-sender-locally branch June 12, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants