Skip to content

fix(metric-issues): Filter contributing issues by detector environment#117367

Merged
malwilley merged 2 commits into
masterfrom
malwilley/metric-detector-env-filter
Jun 10, 2026
Merged

fix(metric-issues): Filter contributing issues by detector environment#117367
malwilley merged 2 commits into
masterfrom
malwilley/metric-detector-env-filter

Conversation

@malwilley

Copy link
Copy Markdown
Member

The metric issue details wasn't handling monitors with an environment very well. It didn't show it in the 'Triggered condition' table, and it didn't query with that environment in the contributing issues section. This PR addresses both of those issues.

The contributing issues section in metric detector issue details was not
filtering by the detector's environment. Pass the snubaQuery environment
through to the issues list query params and the Discover fallback URL.
Display the detector's environment in the triggered condition key-value
list when defined. Also add test coverage for the environment filtering
in contributing issues.
@malwilley malwilley requested a review from a team as a code owner June 10, 2026 20:41
@malwilley malwilley changed the title fix(detectors): Filter contributing issues by detector environment fix(metric-issues): Filter contributing issues by detector environment Jun 10, 2026
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 10, 2026

@saponifi3d saponifi3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ty: for the fast fix!

@malwilley malwilley merged commit 6d001f1 into master Jun 10, 2026
72 checks passed
@malwilley malwilley deleted the malwilley/metric-detector-env-filter branch June 10, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants