fix(metric-issues): Filter contributing issues by detector environment#117367
Merged
Conversation
The contributing issues section in metric detector issue details was not filtering by the detector's environment. Pass the snubaQuery environment through to the issues list query params and the Discover fallback URL.
Display the detector's environment in the triggered condition key-value list when defined. Also add test coverage for the environment filtering in contributing issues.
cvxluo
approved these changes
Jun 10, 2026
saponifi3d
approved these changes
Jun 10, 2026
saponifi3d
left a comment
Contributor
There was a problem hiding this comment.
:ty: for the fast fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric issue details wasn't handling monitors with an environment very well. It didn't show it in the 'Triggered condition' table, and it didn't query with that environment in the contributing issues section. This PR addresses both of those issues.