fix(workflows): Validate delayed workflow tag filter keys#117344
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ceorourke
approved these changes
Jun 10, 2026
ceorourke
left a comment
ceorourke
left a comment
Member
There was a problem hiding this comment.
looks good, would it make sense to clean up invalid rows? I'm not entirely sure how we'd be able to go about that
Member
Author
|
@ceorourke just to confirm, the security bot flag here isn't something we actually care about, right? Or am I mistaken? |
Member
I think so, afaik it will just go to a sentry issue |
amy-chen23
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reject invalid persisted tag filter keys with TAG_KEY_RE before building Snuba columns, and return zero results instead of crashing. Fixes SENTRY-4EBM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject invalid persisted tag filter keys with TAG_KEY_RE before building Snuba columns, and return zero results instead of crashing.
Fixes SENTRY-4EBM