feat(autofix): Handle PR iteration completion and introspection

[joseph-sentry]

Send the ITERATION_COMPLETED webhook when a PR_ITERATION step finishes,
including the pull request payload, code changes, and iteration index, and
record the iteration index on the introspection analytics event. Add
introspect_iteration to evaluate whether revised iteration changes are ready
to update the existing pull request, and route PR_ITERATION through it. Extract
the pull-request and code-changes payload builders into shared helpers.

edited the PR further to remove recover_iteration_feedback, as that's an artifact of an old version of the code that was never cleaned up, so just getting rid of it now

[sentry]

Bug: The functions get_latest_iteration_index and get_iteration_for_insert_index can raise unhandled KeyError or IndexError due to missing safe access patterns and bounds checks.
_{Severity: HIGH}

Suggested Fix

Use safe dictionary access (e.g., metadata.get("iteration_index")) in both functions. Add bounds checking for insert_index in get_iteration_for_insert_index to handle out-of-range values gracefully, similar to how recover_iteration_feedback does.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/sentry/seer/autofix/autofix_agent.py#L234

Potential issue: The functions `get_latest_iteration_index` and
`get_iteration_for_insert_index` access `metadata["iteration_index"]` directly. If a
`PR_ITERATION` block exists in the run state without this key, a `KeyError` will be
raised. This is likely to occur when processing older runs created before the
`iteration_index` key was introduced. The call sites do not handle this exception, which
will cause webhook processing to fail. Additionally, `get_iteration_for_insert_index`
does not perform bounds checking on the `insert_index` it receives from an API endpoint,
which can lead to an `IndexError` if an invalid index is provided.

Also affects:

• src/sentry/seer/autofix/autofix_agent.py:241~241

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[alexsohn1126]

🙌

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 11bbfa9. Configure here.}

[cursor]

Introspection index on wrong steps

Low Severity

Every introspection analytics event now sets iteration_index via get_latest_iteration_index, including root cause, solution, and code changes. Those steps never use PR iteration indices, so events get 0 or a stale iteration from earlier blocks instead of leaving the field unset.

 

^{Reviewed by Cursor Bugbot for commit 11bbfa9. Configure here.}

[cursor]

Invalid zero iteration index emitted

Medium Severity

When a PR_ITERATION block lacks iteration_index metadata, get_latest_iteration_index logs and returns 0. Iteration numbering starts at 1, so ITERATION_COMPLETED webhooks and related analytics can publish an invalid iteration_index instead of failing or deriving the correct value.

Additional Locations (1)

• src/sentry/seer/autofix/on_completion_hook.py#L191-L196

 

^{Reviewed by Cursor Bugbot for commit 11bbfa9. Configure here.}