Skip to content

fix(ourlogs): source observed timestamp from hover-prefetched trace item attributes #116804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit into from
Jun 3, 2026
Merged

fix(ourlogs): source observed timestamp from hover-prefetched trace item attributes #116804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/app/views/explore/hooks/useTraceItemDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ export function usePrefetchTraceItemDetailsOnHover({
projectRef.current = project;
const queryClient = useQueryClient();
const [traceItemMeta, setTraceItemMeta] = useState<TraceItemDetailsMeta | undefined>();
const [traceItemAttributes, setTraceItemAttributes] = useState<
TraceItemResponseAttribute[] | undefined
Comment thread
JoshuaKGoldberg marked this conversation as resolved.
>();

const {hoverProps} = useHover({
onHoverStart: () => {
Expand All @@ -254,6 +257,7 @@ export function usePrefetchTraceItemDetailsOnHover({
queryClient.fetchQuery(options).then(
response => {
setTraceItemMeta(response?.json?.meta);
setTraceItemAttributes(response?.json?.attributes);
},
() => {}
);
Expand All @@ -267,5 +271,5 @@ export function usePrefetchTraceItemDetailsOnHover({
isDisabled: hoverPrefetchDisabled,
});

return {hoverProps, traceItemMeta};
return {hoverProps, traceItemMeta, traceItemAttributes};
}
23 changes: 12 additions & 11 deletions static/app/views/explore/logs/tables/logsTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,20 @@ export const LogRowContent = memo(function LogRowContent({
const logTimestampSeconds = isRegularLogResponseItem(dataRow)
? getLogRowTimestampMillis(dataRow) / 1000
: null;
const {hoverProps, traceItemMeta} = usePrefetchTraceItemDetailsOnHover({
traceItemId: rowId,
projectId: String(dataRow[OurLogKnownFieldKey.PROJECT_ID]),
traceId: String(dataRow[OurLogKnownFieldKey.TRACE_ID]),
traceItemType: TraceItemDataset.LOGS,
referrer: 'api.explore.log-item-details',
timestamp: logTimestampSeconds,
sharedHoverTimeoutRef,
timeout: prefetchTimeout,
});
const {hoverProps, traceItemMeta, traceItemAttributes} =
usePrefetchTraceItemDetailsOnHover({
traceItemId: rowId,
projectId: String(dataRow[OurLogKnownFieldKey.PROJECT_ID]),
traceId: String(dataRow[OurLogKnownFieldKey.TRACE_ID]),
traceItemType: TraceItemDataset.LOGS,
referrer: 'api.explore.log-item-details',
timestamp: logTimestampSeconds,
sharedHoverTimeoutRef,
timeout: prefetchTimeout,
});
const [caseInsensitivity] = useCaseInsensitivity();

const observedTimestamp = traceItemsResult.data?.attributes?.find(
const observedTimestamp = traceItemAttributes?.find(
a => a.name === 'sentry.observed_timestamp_nanos'
);

Expand Down
Loading