fix(workflow_engine): Skip deescalating condition for groups without open periods#116802
Merged
Merged
Conversation
…open periods Group types that do not create open periods (e.g. error groups) were hitting the "No open period found" exception path and emitting noisy info logs. Return False early for these group types so the condition behaves as "not applicable" instead of a known evaluation error. The existing DataConditionEvaluationException is preserved for group types that should have open periods but are missing one, keeping the useful data-integrity signal.
github-actions
Bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
saponifi3d
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref ISWF-2785
The deescalating condition handler was raising a
DataConditionEvaluationExceptionwhen evaluating groups that don't have open periods (which only includes error issues). This is a known behavior, so no need to raise an exception.This adds an early return of
Falsefor issue types that don't create open periods (checked viashould_create_open_periods).We should also follow up with some better documentation of this condition so users aren't confused (although I doubt many users care about this working for error issues since it happens so infrequently compared to metric issues).