Skip to content

feat(seer): Add deliver_feature_result RPC for Seer agent features #116734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-e merged 19 commits into from
Jun 3, 2026

ref(seer): Make delivery handler registry explicit

1c51a11
Select commit
Loading
Failed to load commit list.
Merged

feat(seer): Add deliver_feature_result RPC for Seer agent features #116734

ref(seer): Make delivery handler registry explicit
1c51a11
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: sentry-backend-bugs completed Jun 2, 2026 in 6m 50s

1 issue

sentry-backend-bugs: Found 1 issue (1 high)

High

Circular import causes ImportError: feature_delivery and night_shift/delivery import each other - `src/sentry/seer/agent/feature_delivery.py:8`

Line 8 imports from night_shift.delivery before FeatureRunStatus is defined on line 10; night_shift/delivery.py line 14 then tries to import FeatureRunStatus from the partially-initialized module, raising ImportError on startup. Fix by defining FeatureRunStatus in a standalone types module (e.g. sentry/seer/agent/types.py) that neither file imports from the other.

⏱ 6m 17s · 650.1k in / 36.5k out · $1.32

Annotations

Check failure on line 8 in src/sentry/seer/agent/feature_delivery.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: sentry-backend-bugs

Circular import causes ImportError: feature_delivery and night_shift/delivery import each other 

Line 8 imports from `night_shift.delivery` before `FeatureRunStatus` is defined on line 10; `night_shift/delivery.py` line 14 then tries to import `FeatureRunStatus` from the partially-initialized module, raising `ImportError` on startup. Fix by defining `FeatureRunStatus` in a standalone types module (e.g. `sentry/seer/agent/types.py`) that neither file imports from the other.
View more details on @sentry/warden