ref(autofix): Remove the organizations:autofix-on-explorer feature flag#116165
Conversation
eace939 to
20264c4
Compare
61cb923 to
2bf272c
Compare
This flag is now fully rolled out. Remove the flag registration and collapse all call sites to take the True branch: - `search/snuba/backend.py`: always use `seer_explorer_autofix_last_triggered` - `seer/autofix/issue_summary.py`: always route to `trigger_autofix_agent` - `seer/agent/client_utils.py`: gate only on `organizations:seer-explorer` - `seer/entrypoints/operator.py`: `trigger_autofix` always calls the agent path; the legacy handoff branch in `trigger_handoff` is removed Drop the now-dead `trigger_autofix_legacy` method and its legacy autofix imports. Remove the tests that exercised those dead code paths; the remaining explorer-path tests are de-flagged and their helpers cleaned up. Agent transcript: https://claudescope.sentry.dev/share/4xBciP_4JyKS5m-3OPFGifbPT2RgHiyfmeiyXOGZjAo
After removing `trigger_autofix_legacy`, `get_stopping_point_status`, `get_latest_cause_id`, and `AUTOFIX_FALLBACK_CAUSE_ID` no longer have any callers. Drop them along with the now-unused `AutofixState` import. Co-Authored-By: Claude <[email protected]> Agent transcript: https://claudescope.sentry.dev/share/lVRsatFnt9RUCKag81CcEOLGLMmYq-sL0yPvuoLgmZk
246faa0 to
1eb8368
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1eb8368. Configure here.
| pass | ||
| else: | ||
| response = trigger_legacy_autofix( | ||
| try: |
There was a problem hiding this comment.
Task parameters became dead code after removal
Low Severity
The parameters event_id, user_id, and auto_run_source in _trigger_autofix_task are now completely unused after the legacy code path was removed. They were previously consumed by trigger_legacy_autofix and the user-fetching logic, both of which are gone. The caller in run_automation still computes and passes all three values. While keeping them temporarily is reasonable for in-flight task compatibility, they represent dead code that adds confusion.
Reviewed by Cursor Bugbot for commit 1eb8368. Configure here.


Summary
Third in a stack (follow-up to #116162 and #116164). The
organizations:autofix-on-explorerflag is now true everywhere, so this PR removes it.temporary.py.features.has("organizations:autofix-on-explorer", ...)check to the True branch:search/snuba/backend.py— always use theseer_explorer_autofix_last_triggeredcolumnseer/autofix/issue_summary.py— always route totrigger_autofix_agent; remove the legacy fallbackseer/agent/client_utils.py— gate only onorganizations:seer-explorer(collapse the dual-flagbatch_hasto a singlefeatures.has)seer/entrypoints/operator.py—trigger_autofixalways calls the agent path;trigger_handoffalways fetches viafetch_run_statustrigger_autofix_legacymethod onSeerAutofixOperator(no callers remain) and its dead legacy imports.test_operator.py, rename the no-longer-distinguishedexplorertests, and de-flag the remaining tests.Net: 9 files changed, 42 insertions, 667 deletions.
Agent transcript: https://claudescope.sentry.dev/share/XIAoRxeHQ-AT-i3eUi_fVXryk-kKsNjn_0qaxBkUXqE