ref(autofix): Remove the organizations:autofix-on-explorer feature flag#116165
Open
chromy wants to merge 2 commits into
Open
ref(autofix): Remove the organizations:autofix-on-explorer feature flag#116165chromy wants to merge 2 commits into
chromy wants to merge 2 commits into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
208
to
214
| if not has_access: | ||
| return False, error | ||
|
|
||
| feature_names = [ | ||
| # Access to seer agent | ||
| "organizations:seer-explorer", | ||
| # Access to seer agent powered autofix | ||
| "organizations:autofix-on-explorer", | ||
| ] | ||
|
|
||
| batch_features = features.batch_has( | ||
| feature_names, | ||
| organization=organization, | ||
| actor=actor, | ||
| ) | ||
|
|
||
| if batch_features is None: | ||
| return False, "Feature flag not enabled" | ||
|
|
||
| org_features = batch_features.get(f"organization:{organization.id}", {}) | ||
| if not any(bool(org_features.get(feature_name)) for feature_name in feature_names): | ||
| if not features.has("organizations:seer-explorer", organization, actor=actor): | ||
| return False, "Feature flag not enabled" | ||
|
|
||
| # Check open team membership (the agent requires this for context) |
Contributor
There was a problem hiding this comment.
Bug: Removing the organizations:autofix-on-explorer flag check will revoke Seer agent access for organizations that don't also have the organizations:seer-explorer flag enabled.
Severity: HIGH
Suggested Fix
Before removing the check for the organizations:autofix-on-explorer flag, verify that all organizations with this flag also have the organizations:seer-explorer flag enabled. Alternatively, run a migration script to enable seer-explorer for all organizations that currently have autofix-on-explorer set to true.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/seer/agent/client_utils.py#L208-L214
Potential issue: The function `has_seer_agent_access_with_detail()` is being changed to
only check for the `organizations:seer-explorer` feature flag, removing a check for the
`organizations:autofix-on-explorer` flag. Previously, access was granted if either flag
was enabled. This change will cause a regression for any organization that has
`autofix-on-explorer=True` but `seer-explorer=False`. These organizations will lose
access to Seer agent functionality, including autofix via Slack and direct API
endpoints, because the access check will now incorrectly return `False`.
Did we get this right? 👍 / 👎 to inform future reviews.
Zylphrex
approved these changes
May 26, 2026
chromy
force-pushed
the
chromy/2026-05-26-autofix-remove-legacy-deadcode
branch
from
eace939 to
20264c4
Compare
Base automatically changed from
chromy/2026-05-26-autofix-remove-legacy-deadcode
to
master
May 26, 2026 15:01
This flag is now fully rolled out. Remove the flag registration and collapse all call sites to take the True branch: - `search/snuba/backend.py`: always use `seer_explorer_autofix_last_triggered` - `seer/autofix/issue_summary.py`: always route to `trigger_autofix_agent` - `seer/agent/client_utils.py`: gate only on `organizations:seer-explorer` - `seer/entrypoints/operator.py`: `trigger_autofix` always calls the agent path; the legacy handoff branch in `trigger_handoff` is removed Drop the now-dead `trigger_autofix_legacy` method and its legacy autofix imports. Remove the tests that exercised those dead code paths; the remaining explorer-path tests are de-flagged and their helpers cleaned up. Agent transcript: https://claudescope.sentry.dev/share/4xBciP_4JyKS5m-3OPFGifbPT2RgHiyfmeiyXOGZjAo
chromy
force-pushed
the
chromy/2026-05-26-remove-autofix-on-explorer-flag
branch
from
61cb923 to
2bf272c
Compare
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2bf272c. Configure here.
After removing `trigger_autofix_legacy`, `get_stopping_point_status`, `get_latest_cause_id`, and `AUTOFIX_FALLBACK_CAUSE_ID` no longer have any callers. Drop them along with the now-unused `AutofixState` import. Co-Authored-By: Claude <[email protected]> Agent transcript: https://claudescope.sentry.dev/share/lVRsatFnt9RUCKag81CcEOLGLMmYq-sL0yPvuoLgmZk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third in a stack (follow-up to #116162 and #116164). The
organizations:autofix-on-explorerflag is now true everywhere, so this PR removes it.temporary.py.features.has("organizations:autofix-on-explorer", ...)check to the True branch:search/snuba/backend.py— always use theseer_explorer_autofix_last_triggeredcolumnseer/autofix/issue_summary.py— always route totrigger_autofix_agent; remove the legacy fallbackseer/agent/client_utils.py— gate only onorganizations:seer-explorer(collapse the dual-flagbatch_hasto a singlefeatures.has)seer/entrypoints/operator.py—trigger_autofixalways calls the agent path;trigger_handoffalways fetches viafetch_run_statustrigger_autofix_legacymethod onSeerAutofixOperator(no callers remain) and its dead legacy imports.test_operator.py, rename the no-longer-distinguishedexplorertests, and de-flag the remaining tests.Net: 9 files changed, 42 insertions, 667 deletions.
Agent transcript: https://claudescope.sentry.dev/share/XIAoRxeHQ-AT-i3eUi_fVXryk-kKsNjn_0qaxBkUXqE