fix(replays): Guard against IndexError in query processing with leading logical operators#116117
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(replays): Guard against IndexError in query processing with leading logical operators#116117sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
…ng logical operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
IndexError: list index out of rangeoccurring insrc/sentry/replays/usecases/query/__init__.pywithin theattempt_compressed_conditionfunction.The root cause was that
attempt_compressed_conditionwould unconditionally accessresult[-1]without checking ifresultwas empty. This became an issue whenhandle_search_filtersprocessedsearch_filterslists that began with a logical operator like'AND'or'OR'. In such cases, thelook_backvariable would be set, leading to a call toattempt_compressed_conditionwhile theresultlist was still empty, thus triggering theIndexError.The fix introduces a guard at the beginning of
attempt_compressed_condition: ifresultis empty, theconditionis simply appended, and the function returns. This prevents theIndexErrorby ensuringresult[-1]is only accessed whenresultis guaranteed to contain at least one element, preserving the existing compression logic for valid scenarios.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5NH5