chore(typing): rename mypy stronglist helpers to weaklist#116111
Draft
armenzg wants to merge 1 commit into
Draft
chore(typing): rename mypy stronglist helpers to weaklist#116111armenzg wants to merge 1 commit into
armenzg wants to merge 1 commit into
Conversation
Align helper script and test names with weaklist terminology so tooling names match current typing policy. Treat stronglist->weaklist module renames as replacements in the weaklist-addition guard to keep the transition passing checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stronglist/strongernaming toweaklistnaming.pyproject.toml.stronglist -> weaklistmodule rename as a replacement inprevent_weaklist_additionsso pure rename diffs do not fail the hook.Test plan
.venv/bin/pytest -svv tests/tools/mypy_helpers/test_sort_weaklist.py tests/tools/mypy_helpers/test_check_weaklist.py tests/tools/mypy_helpers/test_prevent_weaklist_additions.py tests/sentry/test_mypy_weaklist.py.venv/bin/prek run -qFollow-up
getsentry/.pre-commit-config.yamlstill points atsort_stronger_modulesandcheck_stronglist; update that in getsentry after this lands.pyproject.tomlstill has the stale commentpython3 -m tools.mypy_helpers.make_weaklist(left unchanged in this PR).Made with Cursor