feat(issues): Two-column activity icons, colors by scttcper · Pull Request #115958 · getsentry/sentry

scttcper · 2026-05-20T22:01:52Z

adds a two column layout based on figma

after

feedback needed the extra bottom space on the scroll container, not tucked inside the activity section. Also narrows the activity section variant prop to sidebar vs standalone. the drawer can ask for md text size separately, which keeps feedback from needing a fake inline variant. Co-Authored-By: Codex GPT-5 <[email protected]>

The feedback activity work made these components shared, but a bunch of names still said Streamlined and lived under the streamline sidebar folder. Move the shared activity section and compact comment input into neutral homes, and rename the comment actions menu so it says what it is. Co-Authored-By: Codex GPT-5 <[email protected]>

Use the Text primitive for non-note activity messages instead of wiring font-size by hand. keeps the activity section closer to the design system now that it is shared outside the old sidebar. Co-Authored-By: Codex GPT-5 <[email protected]>

Feedback spam activity was falling through the shared issue activity copy and showing up as archived forever. Pass the issue category into the activity formatter so feedback keeps the spam label, with a test covering the regression. Co-Authored-By: Codex GPT-5 <[email protected]>

…tion

Adds a FlagPole flag for the updated issue activity row treatment. When enabled, activity rows split actor markers from action icons, color the action icon, and carry that same color onto user avatar rings or system dots. When disabled, the existing one-column activity layout stays in place. Co-Authored-By: Codex GPT-5 <[email protected]>

github-actions · 2026-05-20T22:02:17Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

github-actions · 2026-05-20T22:05:13Z

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

Point the activity row UI at activity-feed-v2 and drop the backend flag registration from this stacked branch. The flag itself now lives in the standalone master PR. Co-Authored-By: Codex GPT-5 <[email protected]>

Make archived activity use the default grey state and move avatar rings to a 2px inset border. Keeps the activity-feed-v2 flag check in place after local testing. Co-Authored-By: Codex GPT-5 <[email protected]>

sentry · 2026-05-20T23:00:27Z

+  const Icon =
+    !useTwoColumnLayout && iconMapping?.componentFunction
+      ? iconMapping.componentFunction({
+          data: item.data,
+          user: item.user,
+          sentry_app: item.sentry_app,
+        })
+      : (iconMapping?.Component ?? null);


Bug: In the two-column layout, CREATE_ISSUE activities display a generic add icon instead of the correct integration-specific icon (e.g., GitHub, Jira) because iconMapping.componentFunction is bypassed.
_{Severity: LOW}

Suggested Fix

Adjust the icon selection logic to ensure iconMapping.componentFunction is executed for GroupActivityType.CREATE_ISSUE activities, even when useTwoColumnLayout is true. The logic that bypasses the component function should be limited to only the activity types it was intended for, such as GroupActivityType.NOTE.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/views/issueDetails/activitySection/index.tsx#L151-L158 Potential issue: In the two-column layout, the logic for selecting an activity icon incorrectly bypasses `iconMapping.componentFunction` for all activity types. While this is intended for note activities, it also affects `GroupActivityType.CREATE_ISSUE`. For `CREATE_ISSUE` activities, the `componentFunction` is responsible for returning integration-specific icons, such as `IconGithub` or `IconJira`. By skipping this function, the UI defaults to displaying a generic `IconAdd`, removing the visual context of the integration used to create the issue.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.}

cursor · 2026-05-20T23:04:29Z

+        ...defaultConfig,
+        icon: theme.tokens.graphics.success.vibrant,
+        iconBorder: theme.tokens.border.success.vibrant,
+      };


SET_RESOLVED_IN_PULL_REQUEST missing from success color config

Medium Severity

The getActivityColorConfig switch statement includes all SET_RESOLVED_* activity types (SET_RESOLVED, SET_RESOLVED_BY_AGE, SET_RESOLVED_IN_RELEASE, SET_RESOLVED_IN_COMMIT) in the success/green color group — but omits GroupActivityType.SET_RESOLVED_IN_PULL_REQUEST. This means resolved-by-PR activities won't receive the green icon and border that all other resolved activity types get, resulting in an inconsistent visual treatment.

^{Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.}

cursor · 2026-05-20T23:04:29Z

 const ActivityInputFrame = styled('div')`
  color: ${p => p.theme.tokens.content.primary};
 `;
+


Sidebar "View more" row misaligned with marker rows

Medium Severity

When the issue-activity-feed-v2 feature flag is enabled, activity items in the sidebar render with a 4-column grid (22px 22px minmax(50px,1fr) auto) via the marker prop, but the "View X more" ActivityTimelineItem doesn't pass a marker, so it gets a 3-column grid. This causes its icon and title to be horizontally misaligned with the activity rows above it — the icon sits where markers are, and the title text shifts left by one column.

^{Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.}

…cons-flag

scttcper and others added 7 commits May 19, 2026 14:23

feat(feedback): reuse streamlined activity section

a30141e

ref(issues): Use Text for activity messages

3ce6f5a

Use the Text primitive for non-note activity messages instead of wiring font-size by hand. keeps the activity section closer to the design system now that it is shared outside the old sidebar. Co-Authored-By: Codex GPT-5 <[email protected]>

Merge branch 'master' into scttcper/feedback-streamlined-activity-sec…

79712b0

…tion

github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 20, 2026

feat(issues): Use activity feed v2 flag

567cf7f

Point the activity row UI at activity-feed-v2 and drop the backend flag registration from this stacked branch. The flag itself now lives in the standalone master PR. Co-Authored-By: Codex GPT-5 <[email protected]>

vercel Bot deployed to Preview May 20, 2026 22:16 View deployment

scttcper removed the Scope: Backend Automatically applied to PRs that change backend components label May 20, 2026

fix(issues): Tune activity marker colors

997a2fb

Make archived activity use the default grey state and move avatar rings to a 2px inset border. Keeps the activity-feed-v2 flag check in place after local testing. Co-Authored-By: Codex GPT-5 <[email protected]>

vercel Bot deployed to Preview May 20, 2026 22:38 View deployment

feat(issues): Use issue activity feed v2 flag

fde9e8e

vercel Bot deployed to Preview May 20, 2026 22:53 View deployment

scttcper changed the title ~~feat(issues): Gate two-column activity icons~~ feat(issues): Two-column activity icons May 20, 2026

scttcper changed the title ~~feat(issues): Two-column activity icons~~ feat(issues): Two-column activity icons, colors May 20, 2026

scttcper requested a review from a team May 20, 2026 22:56

scttcper marked this pull request as ready for review May 20, 2026 22:56

scttcper requested a review from a team as a code owner May 20, 2026 22:56

sentry Bot reviewed May 20, 2026

View reviewed changes

cursor Bot reviewed May 20, 2026

View reviewed changes

Base automatically changed from scttcper/feedback-streamlined-activity-section to master May 21, 2026 18:24

scttcper requested review from a team as code owners May 21, 2026 18:24

Merge remote-tracking branch 'origin/master' into scttcper/activity-i…

1e24e9f

…cons-flag

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(issues): Two-column activity icons, colors#115958

feat(issues): Two-column activity icons, colors#115958
scttcper wants to merge 11 commits into
masterfrom
scttcper/activity-icons-flag

scttcper commented May 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

sentry Bot May 20, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot May 20, 2026

Uh oh!

cursor Bot May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

scttcper commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Type Coverage Diff

Uh oh!

sentry Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 20, 2026

Choose a reason for hiding this comment

SET_RESOLVED_IN_PULL_REQUEST missing from success color config

Uh oh!

cursor Bot May 20, 2026

Choose a reason for hiding this comment

Sidebar "View more" row misaligned with marker rows

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

scttcper commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading

`SET_RESOLVED_IN_PULL_REQUEST` missing from success color config