feat(explore): heatmap tooltip trace links#115925
Conversation
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| getSeriesValue(serie, 2) ?? 0, | ||
| 4, | ||
| false | ||
| ); |
There was a problem hiding this comment.
Heatmap tooltip shows log-transformed Z-axis counts
Medium Severity
When scale="log" (used by MetricsHeatMap), heatMap.tsx stores Z values as Math.log1p(zValue) in the series data. The tooltip reads this transformed value via getSeriesValue(serie, 2) and formats it with formatAbbreviatedNumber, displaying the log-transformed number instead of the actual event count (e.g., ~6.9 instead of 1,000). An inverse transform like Math.expm1 is needed before formatting.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3dac374. Configure here.
There was a problem hiding this comment.
going to deal with the log stuff in a different PR after i talk to Will and see how it's being calculated in the backend and how (or if) i'd need to transform it on the frontend.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
We have import {useRenderToString} from '@sentry/scraps/renderToString' to generate markup from our components to pass to eCharts
AH i had no idea, thanks for letting me know 😌 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58d6674. Configure here.
| return data; | ||
| } | ||
|
|
||
| const value = (data as {value?: unknown} | null | undefined)?.value; |
There was a problem hiding this comment.
nit: Any way we can get rid of this type cast 👀
There was a problem hiding this comment.
unfortunately not, the original typing for this value is from e-charts and this type in particular is not exported 😢
3 participants
I've added a
View related traceslink in the tooltip so that users can use heat maps to dig in to problem areas or general trends. The link should direct them to the traces page with the correct cross-event and page filters populated.Couple things to note here:
Closes DAIN-1641