ref(onboarding): migrate createSampleEventButton off browserHistory#115921
Closed
evanpurkhiser wants to merge 1 commit into
Closed
Conversation
Replace the `browserHistory.push` call in `CreateSampleEventButton` with a navigate prop supplied by a function wrapper that calls `useNavigate()`. Split the props type so the public `ButtonProps` union stays intact for callers.
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
Superseded by #115830 which converted this file to a functional component using useNavigate directly. |
auto-merge was automatically disabled
May 20, 2026 19:27
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
browserHistory.pushcall inCreateSampleEventButtonwith a navigate prop supplied by a function wrapper that callsuseNavigate(). Split the props type so the publicButtonPropsunion stays intact for callers.