feat(dashboards): Add span-first support for web vital dashboard#115882
Open
Lms24 wants to merge 4 commits into
Open
feat(dashboards): Add span-first support for web vital dashboard#115882Lms24 wants to merge 4 commits into
Lms24 wants to merge 4 commits into
Conversation
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new
browser.web_vital.<vital>.valueattributes to the web vital pre built dashboard queries. This ensures the pre-built dashboard is compatible with streamed v2 web vital spans and attributes.I left the hard-coded
scoreattributes as-is, since these seem to be handled correctly already.Reviewers, please let me know if you want to tackle this differently or are already working on it. I mainly oriented myself on #113046 but happy to change anything or close the PR!
My naive assumption was that through coalescing we can switch to querying the new attributes and it works for the old ones as well. Tested with projects sending transactions as well as projects sending v2 spans and both still seem to work.