chore(alerts): Remove incident serializer usages#115845
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d0942c5. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
ceorourke
changed the title
Member
Author
|
Will rebase on top of #115850 |
ceorourke
force-pushed
the
ceorourke/rm-incident-serializer
branch
from
7127d2b to
44b39c8
Compare
saponifi3d
reviewed
May 19, 2026
| kwargs["incident"] = gop | ||
| return args, kwargs | ||
|
|
||
| # PUT: update_incident_status operates on the legacy Incident model. |
Contributor
There was a problem hiding this comment.
is there anything from this method that should also be cleaned up as part of removing the PUT request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all direct references to the
IncidentSerializerandDetailedIncidentSerializer.This includes removing the
OrganizationIncidentDetailsEndpointPUT method entirely, but it was never published, is not used by the front end, and hasn't received any API requests in at least 30 days.This also includes removing the metric alert Slack unfurl code, but the URL it checks doesn't match the current metric issues details page so it would only apply to old links being shared.
The serializer cannot fully be removed until we are no longer using the
AlertRuleSerializerbecause whenlatestIncidentis passed to the expand params this serializer is still used.