Skip to content

chore(issues): Indicate duration when "Since First Seen" is selected #115533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amy-chen23 wants to merge 13 commits into
base: master
Choose a base branch
from
+17 −6
Draft

chore(issues): Indicate duration when "Since First Seen" is selected #115533

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f733270
added date to Since First Seen dropdown
amy-chen23 May 13, 2026
8029271
added duration when since first seen is selected
amy-chen23 May 18, 2026
fc3c478
Apply suggestion from @scttcper
amy-chen23 May 18, 2026
6c84f84
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] May 18, 2026
7e8fcba
changed to from round to floor to avoid premature day rounding
amy-chen23 May 18, 2026
5538f9f
reusing duration calc from sidebar
amy-chen23 May 19, 2026
b5f89de
fixed rounding issue w/ test
amy-chen23 May 19, 2026
94c5622
adding minutes and gave priority to since first seen (over default)
amy-chen23 May 19, 2026
4b0b92d
using string parsing to shorten Since First Seen b/c rounding is havi…
amy-chen23 May 20, 2026
368df85
moving props.defaultOptions back to original place so that 90 day max…
amy-chen23 May 20, 2026
cad6e89
added guard for garbled text for 'a few seconds old'
amy-chen23 May 20, 2026
f5cbc5a
Merge branch 'master' into issues-indicate-duration
shashjar May 21, 2026
1183830
got rid of helper function and stopped abbreviating the time range dr…
amy-chen23 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion static/app/views/issueDetails/streamline/eventDetailsHeader.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ describe('EventDetailsHeader', () => {

expect(screen.getByRole('button', {name: 'All Envs'})).toBeInTheDocument();
// Date selection is based on first seen unless selected by the user
expect(screen.getByRole('button', {name: 'Since First Seen'})).toBeInTheDocument();
expect(
screen.getByRole('button', {name: 'Since First Seen (20D)'})
).toBeInTheDocument();
expect(screen.getByPlaceholderText('Filter events\u2026')).toBeInTheDocument();
expect(
screen.getByRole('button', {
Expand Down
6 changes: 4 additions & 2 deletions static/app/views/issueDetails/streamline/eventDetailsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from 'sentry/components/timeRangeSelector';
import {getRelativeSummary} from 'sentry/components/timeRangeSelector/utils';
import {TourElement} from 'sentry/components/tours/components';
import {t} from 'sentry/locale';
import {t, tct} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import type {Project} from 'sentry/types/project';
Expand Down Expand Up @@ -181,7 +181,9 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
{period === defaultStatsPeriod &&
!defaultStatsPeriod.isMaxRetention &&
shouldShowSinceFirstSeenOption
? t('Since First Seen')
? tct('Since First Seen ([period])', {
Comment thread
shashjar marked this conversation as resolved.
period: triggerProps.children,
})
: triggerProps.children}
</TimeRangeSelectTrigger>
)}
Expand Down
Loading