Skip to content

ref(flex) run codemod on orphaned files#115393

Open
JonasBa wants to merge 4 commits into
masterfrom
jb/codemod/flex-orphaned-05-12
Open

ref(flex) run codemod on orphaned files#115393
JonasBa wants to merge 4 commits into
masterfrom
jb/codemod/flex-orphaned-05-12

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented May 12, 2026

Re-running the flex codemod on some orphaned files (it's been a while since the last time we ran it)

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.49%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dacead3. Configure here.

details: (
<Container as="span" width="20rem">
{r.desc}
</Container>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing display: inline-block breaks width on span

Medium Severity

The old Details styled span had display: inline-block and width: 20rem. The replacement Container as="span" width="20rem" drops the display: inline-block. Since span defaults to inline display, the width property has no effect on inline elements, so the 20rem width constraint on role descriptions is lost.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dacead3. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spans are inline block elements by default (we do not override it)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasBa you are agreeing with Cursor here? span defaults to inline which does not allow width, so we need display="inline-block" on the Container.

Comment thread static/app/components/customResolutionModal.tsx Outdated
Comment thread static/gsAdmin/views/home.tsx
Rename local Container definitions that shadow the imported Container
from @sentry/scraps/layout, fixing TS2440 and TS2322 errors in tsgo.

Co-Authored-By: Claude <[email protected]>
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the cursor comments are all legit here! Otherwise only saw one thing.

width="100%"
height="100%"
position="relative"
style={{minHeight}}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codemod wouldn't have caught this, but style={{ minHeight }} can be minHeight={minHeight}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent use minHeight prop here (if its an int type, then append the px unit).

Also apply the display="block" and "inline-block" suggestions from your previous comments

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes have been successfully committed and pushed! Here's what I fixed:

Changes Made

  1. contentSliderDiff/index.tsx (line 44):

    • Replaced style={{minHeight}} with the minHeight prop
    • Added logic to append 'px' unit if the value is a number: minHeight={typeof minHeight === 'number' ? ${minHeight}px : minHeight}
  2. customResolutionModal.tsx (line 199):

    • Added display="inline-block" to the Container as="span" element
    • This ensures the minHeight property works correctly on the placeholder span
  3. gsAdmin/views/home.tsx (lines 112, 139, 156):

    • Added display="block" to all three Container as="label" elements
    • This ensures the labels display as block elements and margin-top applies correctly

All changes align with the design system guidelines and address the feedback from @natemoo-re and previous bot comments about missing display properties.

Open in Web Open in Cursor 

- Use minHeight prop instead of style attribute in contentSliderDiff
- Add display inline-block to Container as span in customResolutionModal
- Add display block to Container as label elements in gsAdmin/views/home

Co-authored-by: Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants