ref(flex) run codemod on orphaned files#115393
Conversation
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dacead3. Configure here.
| details: ( | ||
| <Container as="span" width="20rem"> | ||
| {r.desc} | ||
| </Container> |
There was a problem hiding this comment.
Missing display: inline-block breaks width on span
Medium Severity
The old Details styled span had display: inline-block and width: 20rem. The replacement Container as="span" width="20rem" drops the display: inline-block. Since span defaults to inline display, the width property has no effect on inline elements, so the 20rem width constraint on role descriptions is lost.
Reviewed by Cursor Bugbot for commit dacead3. Configure here.
There was a problem hiding this comment.
spans are inline block elements by default (we do not override it)
There was a problem hiding this comment.
@JonasBa you are agreeing with Cursor here? span defaults to inline which does not allow width, so we need display="inline-block" on the Container.
Rename local Container definitions that shadow the imported Container from @sentry/scraps/layout, fixing TS2440 and TS2322 errors in tsgo. Co-Authored-By: Claude <[email protected]>
natemoo-re
left a comment
There was a problem hiding this comment.
Think the cursor comments are all legit here! Otherwise only saw one thing.
| width="100%" | ||
| height="100%" | ||
| position="relative" | ||
| style={{minHeight}} |
There was a problem hiding this comment.
Codemod wouldn't have caught this, but style={{ minHeight }} can be minHeight={minHeight}
There was a problem hiding this comment.
@cursoragent use minHeight prop here (if its an int type, then append the px unit).
Also apply the display="block" and "inline-block" suggestions from your previous comments
There was a problem hiding this comment.
The changes have been successfully committed and pushed! Here's what I fixed:
Changes Made
-
contentSliderDiff/index.tsx (line 44):
- Replaced
style={{minHeight}}with theminHeightprop - Added logic to append 'px' unit if the value is a number:
minHeight={typeof minHeight === 'number' ?${minHeight}px: minHeight}
- Replaced
-
customResolutionModal.tsx (line 199):
- Added
display="inline-block"to theContainer as="span"element - This ensures the
minHeightproperty works correctly on the placeholder span
- Added
-
gsAdmin/views/home.tsx (lines 112, 139, 156):
- Added
display="block"to all threeContainer as="label"elements - This ensures the labels display as block elements and margin-top applies correctly
- Added
All changes align with the design system guidelines and address the feedback from @natemoo-re and previous bot comments about missing display properties.
- Use minHeight prop instead of style attribute in contentSliderDiff - Add display inline-block to Container as span in customResolutionModal - Add display block to Container as label elements in gsAdmin/views/home Co-authored-by: Jonas <[email protected]>




Re-running the flex codemod on some orphaned files (it's been a while since the last time we ran it)