fix(ourlogs): stabilized column widths during scrolling#115389
Open
JoshuaKGoldberg wants to merge 2 commits into
Open
fix(ourlogs): stabilized column widths during scrolling#115389JoshuaKGoldberg wants to merge 2 commits into
JoshuaKGoldberg wants to merge 2 commits into
Conversation
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7902a63. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is another one that ballooned a bit from where I thought it was. We don't actually store grid column widths by default / on page load, they're just CSS
minmaxwithauto. The user dragging a column to manually resize just sets that column incolumnWidthsRef.current.As a result, LOGS-796 happens when:
When there's content in the column cells, the table's grid gives that column more
autowidth. When there isn't content, lessautowidth.The fix in this PR is to "lock" the columns when scrolling starts. This is done by measuring the current DOM width and setting it in the DOM styles. The columns get "unlocked" when the page changes from a browser size or field reorder.
We can't unlock when scroll ends, because then we'd get a sudden shift from columns reverting to
autowidths from the manually set ones.Fixes LOGS-796.