Skip to content

chore(onboarding): Exclude flutter profiling from SCM info cards#115383

Merged
jaydgoss merged 1 commit into
masterfrom
jaygoss/exclude-flutter-profiling-from-onboarding
May 12, 2026
Merged

chore(onboarding): Exclude flutter profiling from SCM info cards#115383
jaydgoss merged 1 commit into
masterfrom
jaygoss/exclude-flutter-profiling-from-onboarding

Conversation

@jaydgoss
Copy link
Copy Markdown
Member

Drop PROFILING from flutter in platformProductInfo.generated.ts. Flutter profiling is still alpha and iOS/macOS-only per the SDK team, but sentry-docs frontmatter doesn't declare it notSupported, so the previous regen surfaced it as available for new-project onboarding.

Confirmed by Chris Aigner (Flutter SDK) in #team-value-discovery after the docs-frontmatter audit on #115092.

Mechanism

Adds a PRODUCT_EXCLUSIONS override map to scripts/genPlatformProductInfo.ts for (platform, product) combinations where the docs declare support but SDK owners have asked us not to surface the feature. Each entry is documented with rationale so future regens don't quietly drop or restore overrides.

Regen

pnpm gen:platform-info against a sibling sentry-docs checkout.

Test plan

  • scmPlatformFeatures.spec.tsx passes (25/25 locally)
  • Generated diff is one line: ProductSolution.PROFILING removed from flutter

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.49%

Flutter profiling is still alpha and iOS/macOS-only per the SDK team
(Chris Aigner), but sentry-docs frontmatter doesn't declare it
notSupported. Add a per-platform product-exclusion override in the
codegen script and regenerate, dropping PROFILING from flutter in
the generated info-card map.
@jaydgoss jaydgoss force-pushed the jaygoss/exclude-flutter-profiling-from-onboarding branch from 976b34d to ed03316 Compare May 12, 2026 18:03
@jaydgoss jaydgoss marked this pull request as ready for review May 12, 2026 18:04
@jaydgoss jaydgoss requested a review from a team as a code owner May 12, 2026 18:04
@jaydgoss jaydgoss requested review from a team May 12, 2026 18:04
Copy link
Copy Markdown
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the comments

@jaydgoss jaydgoss merged commit de42071 into master May 12, 2026
67 checks passed
@jaydgoss jaydgoss deleted the jaygoss/exclude-flutter-profiling-from-onboarding branch May 12, 2026 18:57
nikkikapadia pushed a commit that referenced this pull request May 12, 2026
…5383)

Drop `PROFILING` from `flutter` in `platformProductInfo.generated.ts`.
Flutter profiling is still alpha and iOS/macOS-only per the SDK team,
but `sentry-docs` frontmatter doesn't declare it `notSupported`, so the
previous regen surfaced it as available for new-project onboarding.

Confirmed by Chris Aigner (Flutter SDK) in
[#team-value-discovery](https://sentry.slack.com/archives/CA2V2LBDL/p1778178531405179)
after the docs-frontmatter audit on
[#115092](#115092).

### Mechanism

Adds a `PRODUCT_EXCLUSIONS` override map to
`scripts/genPlatformProductInfo.ts` for (platform, product) combinations
where the docs declare support but SDK owners have asked us not to
surface the feature. Each entry is documented with rationale so future
regens don't quietly drop or restore overrides.

### Regen

`pnpm gen:platform-info` against a sibling `sentry-docs` checkout.

## Test plan
- [ ] `scmPlatformFeatures.spec.tsx` passes (25/25 locally)
- [ ] Generated diff is one line: `ProductSolution.PROFILING` removed
from `flutter`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants