chore(onboarding): Exclude flutter profiling from SCM info cards#115383
Merged
jaydgoss merged 1 commit intoMay 12, 2026
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
Flutter profiling is still alpha and iOS/macOS-only per the SDK team (Chris Aigner), but sentry-docs frontmatter doesn't declare it notSupported. Add a per-platform product-exclusion override in the codegen script and regenerate, dropping PROFILING from flutter in the generated info-card map.
976b34d to
ed03316
Compare
Abdkhan14
approved these changes
May 12, 2026
Contributor
Abdkhan14
left a comment
There was a problem hiding this comment.
Nice, thanks for the comments
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
…5383) Drop `PROFILING` from `flutter` in `platformProductInfo.generated.ts`. Flutter profiling is still alpha and iOS/macOS-only per the SDK team, but `sentry-docs` frontmatter doesn't declare it `notSupported`, so the previous regen surfaced it as available for new-project onboarding. Confirmed by Chris Aigner (Flutter SDK) in [#team-value-discovery](https://sentry.slack.com/archives/CA2V2LBDL/p1778178531405179) after the docs-frontmatter audit on [#115092](#115092). ### Mechanism Adds a `PRODUCT_EXCLUSIONS` override map to `scripts/genPlatformProductInfo.ts` for (platform, product) combinations where the docs declare support but SDK owners have asked us not to surface the feature. Each entry is documented with rationale so future regens don't quietly drop or restore overrides. ### Regen `pnpm gen:platform-info` against a sibling `sentry-docs` checkout. ## Test plan - [ ] `scmPlatformFeatures.spec.tsx` passes (25/25 locally) - [ ] Generated diff is one line: `ProductSolution.PROFILING` removed from `flutter`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
PROFILINGfromflutterinplatformProductInfo.generated.ts. Flutter profiling is still alpha and iOS/macOS-only per the SDK team, butsentry-docsfrontmatter doesn't declare itnotSupported, so the previous regen surfaced it as available for new-project onboarding.Confirmed by Chris Aigner (Flutter SDK) in #team-value-discovery after the docs-frontmatter audit on #115092.
Mechanism
Adds a
PRODUCT_EXCLUSIONSoverride map toscripts/genPlatformProductInfo.tsfor (platform, product) combinations where the docs declare support but SDK owners have asked us not to surface the feature. Each entry is documented with rationale so future regens don't quietly drop or restore overrides.Regen
pnpm gen:platform-infoagainst a siblingsentry-docscheckout.Test plan
scmPlatformFeatures.spec.tsxpasses (25/25 locally)ProductSolution.PROFILINGremoved fromflutter