ref(dashboards): Remove visibility-dashboards-async-queue flag#115373
Draft
DominikB2014 wants to merge 3 commits into
Draft
ref(dashboards): Remove visibility-dashboards-async-queue flag#115373DominikB2014 wants to merge 3 commits into
DominikB2014 wants to merge 3 commits into
Conversation
The visibility-dashboards-async-queue flag is fully rolled out, so the feature-gated code paths are no longer reachable. Remove the flag check from the widget query queue hook and every widget query hook, drop the non-queue 429 retry fallback, and clean up unused imports. Make WidgetQueryQueueProvider self-aware so nested providers no-op, and wrap WidgetCardDataLoader in a provider so every consumer of the data loader (including off-dashboard callers like eapSidebarCharts) has a queue. useWidgetQueryQueue now returns a non-optional queue and every `if (queue)` branch is gone. Update affected tests to render under a WidgetQueryQueueProvider, and update the hook test mocks to provide a queue that runs items synchronously. Refs BROWSE-497 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
…affic-through-dashboards-queuer
The widget viewer modal renders WidgetQueries/IssueWidgetQueries/ ReleaseWidgetQueries directly without going through WidgetCardDataLoader, so it didn't pick up the queue provider that the loader self-wraps now. Add the provider at the modal root so all internal widget query paths have access to the queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
visibility-dashboards-async-queueflag is fully rolled out, so the feature-gated code paths are no longer reachable. This PR removes the frontend flag and the now-dead code:organization.features.includes('visibility-dashboards-async-queue')check fromuseWidgetQueryQueueand every dashboards widget query hook.retry/retryDelayusinggetRetryDelay+RequestError) since the queue now handles retries viaasyncRetryerOptions.WidgetQueryQueueProviderself-aware so nesting is a no-op, and wrapsWidgetCardDataLoaderin a provider. Off-dashboard consumers of the data loader (e.g.eapSidebarCharts) now also get a queue.useWidgetQueryQueuereturns a non-optional queue and everyif (queue)branch is removed from the hooks and fromdashboard.tsxcleanup.Test plan
pnpm run lint:jsclean for all touched filespnpm test-ci static/app/views/dashboards/ static/app/views/performance/transactionSummary/transactionOverview/— 114 suites / 1120 tests passRefs BROWSE-497