fix(ai-conversations): Fix page filter race condition on conversation detail page#115366
Merged
obostjancic merged 3 commits intoMay 12, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
… detail page Opening a conversation detail URL without query params caused PageFiltersContainer to restore stale project/datetime from localStorage, resulting in empty results when the stored project didn't match the conversation's actual project. - Add skipLoadLastUsed on detail page to prevent localStorage restoration - Include pre-padded start/end and project in table detail URLs so PageFiltersContainer picks them up directly - Fall back to ALL_ACCESS_PROJECTS and statsPeriod=30d when no filters are present (bare link / Slack link scenario) Refs TET-2314 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Pass projects to the new ConversationIdLink call site added in 50408b5.
obostjancic
force-pushed
the
ognjenbostjancic/tet-2314-conversation-id-url-without-any-get-params-forces-the-last
branch
from
0c0bf65 to
b09f0f7
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Also check selection.datetime.period (not just start) to detect explicitly set datetime filters. Avoids silently overriding relative periods like "7d" with the 30d fallback.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad02d1f. Configure here.
vgrozdanic
approved these changes
May 12, 2026
obostjancic
deleted the
ognjenbostjancic/tet-2314-conversation-id-url-without-any-get-params-forces-the-last
branch
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes page filter initialization race on the conversation detail page that caused empty results when opening via direct link or navigating from the table.
skipLoadLastUsedon detail page prevents localStorage restorationRefs TET-2314