Skip to content

ref(ds): Remove reservoir sampling rule #115365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dav1dde merged 8 commits into from
May 13, 2026
+16 −29
Merged

ref(ds): Remove reservoir sampling rule #115365

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b453498
ref(ds): Remove reservoir sampling rule
Dav1dde May 12, 2026
f4ead1d
add missing types
Dav1dde May 12, 2026
066c8b4
bug bot findings
Dav1dde May 12, 2026
603f403
fix tests
Dav1dde May 12, 2026
731ce9d
another drive by fix
Dav1dde May 12, 2026
9f63dad
unused limit field
Dav1dde May 12, 2026
d47adcb
limit is gone
Dav1dde May 12, 2026
62f0198
typing hint
Dav1dde May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/dynamic_sampling/rules/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class RuleType(Enum):
REVERSE_RESERVED_IDS = {value: key for key, value in RESERVED_IDS.items()}


SamplingValueType = Literal["sampleRate", "factor", "reservoir", "minimumSampleRate"]
SamplingValueType = Literal["sampleRate", "factor", "minimumSampleRate"]
Comment thread
cursor[bot] marked this conversation as resolved.


# (RaduW) Maybe we can split in two types, one for reservoir and one for sampleRate and factor
Expand Down
4 changes: 2 additions & 2 deletions static/gsAdmin/views/dynamicSamplingPanel.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('Dynamic Sampling Panel', () => {

const rule1 = {
samplingValue: {
type: 'reservoir',
type: 'minimumSampleRate',
Comment thread
cursor[bot] marked this conversation as resolved.
limit: 100,
},
type: 'transaction',
Expand All @@ -163,7 +163,7 @@ describe('Dynamic Sampling Panel', () => {

const rule2 = {
samplingValue: {
type: 'reservoir',
type: 'minimumSampleRate',
limit: 300,
},
type: 'transaction',
Expand Down
8 changes: 1 addition & 7 deletions static/gsAdmin/views/dynamicSamplingPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type RuleV2 = {
};
id: number;
samplingValue: {
type: 'factor' | 'sampleRate' | 'reservoir';
type: 'factor' | 'sampleRate';
value: number;
limit?: number;
};
Expand Down Expand Up @@ -335,9 +335,6 @@ function DynamicSamplingRulesTable({
) {
return `${round(samplingValue.value * 100)}%`;
}
if (samplingValue.type === 'reservoir') {
return '100%';
}
return `* ${round(samplingValue.value)}`;
};

Expand All @@ -348,9 +345,6 @@ function DynamicSamplingRulesTable({
if (rule.samplingValue.type === 'sampleRate') {
return round(rule.samplingValue.value - baseSampleRate);
}
if (rule.samplingValue.type === 'reservoir') {
Comment thread
cursor[bot] marked this conversation as resolved.
return 1;
}
return round(rule.samplingValue.value - 1);
};

Expand Down
Loading