ref(issues): Remove InterimSection#115355
Conversation
InterimSection was only a temporary adapter around FoldSection. Replace the call sites with FoldSection directly and let the section context accept the string keys those call sites already used. Also keeps jump-to limited to the known issue detail sections, so arbitrary drawer/sidebar section keys don't show up there. Co-authored-by: Codex GPT-5 <[email protected]>
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
InterimSection was the last consumer of this exported link after the section cleanup. Drop it so knip stays quiet. Co-authored-by: Codex GPT-5 <[email protected]>
Highlights rendered the empty state while the detailed project request was still pending, then kept the loading spinner around after the request settled. That left issue details stuck with a loading indicator and knocked over the acceptance shards. Render loading only while the request is pending, and keep the now-local prop types unexported so knip stays quiet. Co-Authored-By: Codex <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 459e45c. Configure here.
| ))} | ||
| </ContentWrapper> | ||
| </InterimSection> | ||
| </FoldSection> |
There was a problem hiding this comment.
Dropped disableCollapsePersistence in trace drawer general info sections
Medium Severity
Both span and transaction GeneralInfo components previously passed disableCollapsePersistence to InterimSection, which forwarded it to FoldSection. During migration, that prop was dropped. Since FoldSection defaults disableCollapsePersistence to false, these "General" sections in the trace drawer will now persist their collapsed state to localStorage. Every other FoldSection in the trace drawer still explicitly sets disableCollapsePersistence, making this inconsistency clearly unintentional.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 459e45c. Configure here.
InterimSection was just a temporary wrapper around FoldSection while the streamlined issue details UI was landing. It was added in #74224 . This replaces those call sites with FoldSection directly and deletes the adapter.
2 participants
InterimSection was just a temporary wrapper around FoldSection while the streamlined issue details UI was landing. It was added in #74224 . This replaces those call sites with FoldSection directly and deletes the adapter.