feat(highlights): New loading state, stronger project types#115352
Merged
Conversation
Highlights needs the project detail response before it can safely render or edit rows. Keep the section loading until that record exists, then let the data renderer stay on the normal path. Also swaps the big spinner for a row-shaped loading state so the section looks more like the grid it is about to render. Co-authored-by: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
# Conflicts: # static/app/components/events/highlights/highlightsDataSection.tsx
scttcper
changed the title
roggenkemper
approved these changes
May 12, 2026
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
Highlights needs the project detail response before it can safely render or edit rows. Keep the section loading until that record exists (behavior unchanged). Part of #115024 Swaps the big spinner for a row-shaped loading state so the section looks more like the grid it is about to render. before <img width="966" height="196" alt="image" src="https://github.com/user-attachments/assets/9a7b0268-4eaf-4b9a-8b25-a2c77d0492de" /> after <img width="955" height="212" alt="image" src="https://github.com/user-attachments/assets/4f6e9fad-9b5a-4fca-974c-002426b5b318" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights needs the project detail response before it can safely render or edit rows. Keep the section loading until that record exists (behavior unchanged). Part of #115024
Swaps the big spinner for a row-shaped loading state so the section looks more like the grid it is about to render.
before
after