feat(snapshots): Add endpoint for downloading images zip#115337
Merged
NicoHinderling merged 1 commit intoMay 12, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
github-actions
Bot
added
the
Scope: Backend
github-actions
Bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.47% |
NicoHinderling
force-pushed
the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
from
367ae5e to
1ebb99a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
from
1ebb99a to
677bcff
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e990e2b. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
from
5db78fd to
1c91f37
Compare
NicoHinderling
force-pushed
the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
from
1c91f37 to
f9b8a7e
Compare
NicoHinderling
force-pushed
the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
from
f9b8a7e to
80054f9
Compare
rbro112
approved these changes
May 11, 2026
NicoHinderling
deleted the
05-11-feat_snapshots_add_endpoint_for_downloading_images_zip
branch
NicoHinderling
added a commit
that referenced
this pull request
May 12, 2026
Screenshots: <img width="688" height="800" alt="image" src="https://github.com/user-attachments/assets/9a234440-405a-428f-b5fe-a8969e94e359" /> <img width="1274" height="1842" alt="image" src="https://github.com/user-attachments/assets/60e7b20d-45a9-465c-81fd-504ca8f4b931" /> ## Summary Frontend companion to #115337. Adds a "Download Images" action to the snapshot header dropdown menu that fetches the zip from the new download endpoint and triggers a browser download. Also cleans up the `SnapshotImage` type and test fixtures: - Removes `content_hash` from the frontend `SnapshotImage` interface — it's an internal storage detail not needed by the UI - Stops filtering `content_hash` from the metadata copy-to-clipboard JSON (since the field is gone) - Filters out `null` values from the metadata JSON to reduce noise - Reorders dropdown menu items: Build Metadata → View Base Build → Download Images → Rerun Status Checks → Delete ## Test plan - [ ] Open a snapshot detail page and verify the dropdown menu shows the new "Download Images" option - [ ] Click "Download Images" and confirm the zip downloads with the correct filename - [ ] Verify the metadata copy button no longer includes `content_hash` or null fields - [ ] Confirm existing snapshot stories still render correctly without `content_hash`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/preprodartifacts/snapshots/<id>/download/) that bundles all snapshot images into a zip file. Images are fetched concurrently in batches (32 workers, 200 per batch) and deduplicated by content hash before zipping. The response is streamed as aStreamingHttpResponse— chunks are yielded as each batch is zipped, so the client starts receiving data immediately without buffering the entire archive in memory.project_preprod_artifact_download.py), which also usesStreamingHttpResponsefor large file downloads._DrainableBuffersozipfilewrites data descriptors (no seeking back to update headers), enabling true streaming output.**dict()spread pattern inSnapshotImageResponseconstruction with explicit field assignments (description,tags). The old approach silently forwarded unknown fields via**kwargsfiltering, which was brittle and hard to follow.Test plan