Skip to content

ref(forms): Migrate addCodeOwnerModal off legacy Form #115256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priscilawebdev wants to merge 19 commits into
base: master
Choose a base branch
from
+225 −202
Open

ref(forms): Migrate addCodeOwnerModal off legacy Form #115256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7321024
ref(forms): Migrate addCodeOwnerModal off legacy Form
priscilawebdev May 11, 2026
141dcad
ref(forms): Fix addCodeOwnerModal spacing
priscilawebdev May 11, 2026
6030602
ref(forms): Push integrations query into LinkCodeOwners
priscilawebdev May 11, 2026
bfe0414
ref(forms): Swap useStore for form.Subscribe
priscilawebdev May 11, 2026
9ee4f31
ref(forms): Clean up a11y and translations
priscilawebdev May 11, 2026
e3d2a9c
ref(forms): Replace styled wrappers with scraps primitives
priscilawebdev May 11, 2026
0c6d99b
ref(forms): Use Text as=p in ErrorMessage
priscilawebdev May 11, 2026
2f8e45e
ref(forms): Lift shared Container out of file panels
priscilawebdev May 11, 2026
f73115b
test(forms): Wait for Add File button to be enabled before clicking
priscilawebdev May 11, 2026
e3fd119
ref(forms): Use space.lg for file panel padding
priscilawebdev May 11, 2026
c605a76
ref(forms): Tighten mutation error handling
priscilawebdev May 11, 2026
ff5b4db
ref(forms): Drop unsafe cast on ErrorMessage prop
priscilawebdev May 11, 2026
e2d7602
fix(forms): Treat codeowners error raw as string array
priscilawebdev May 11, 2026
10aab06
Merge branch 'master' into priscila/ref/migrate-addcodeownermodal
priscilawebdev May 11, 2026
fd28d88
Update static/app/views/settings/project/projectOwnership/addCodeOwne…
priscilawebdev May 12, 2026
a3b289c
Merge branch 'master' into priscila/ref/migrate-addcodeownermodal
priscilawebdev May 12, 2026
b52357b
ref: submit mutation via form.SubmitButton
priscilawebdev May 12, 2026
6b630d9
Merge remote-tracking branch 'origin/master' into priscila/ref/migrat…
priscilawebdev May 12, 2026
b6a5902
fix(forms): narrow mutation.error to RequestError
priscilawebdev May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions static/app/views/settings/project/projectOwnership/addCodeOwnerModal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {RepositoryFixture} from 'sentry-fixture/repository';
import {RepositoryProjectPathConfigFixture} from 'sentry-fixture/repositoryProjectPathConfig';

import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
import {selectEvent} from 'sentry-test/selectEvent';

import {
makeClosableHeader,
Expand Down Expand Up @@ -84,13 +83,14 @@ describe('AddCodeOwnerModal', () => {
/>
);

await waitFor(() =>
selectEvent.select(
screen.getByText('--'),
`Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`
)
await userEvent.click(await screen.findByRole('textbox'));
await userEvent.click(
await screen.findByRole('menuitemradio', {
name: `Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`,
})
);
expect(screen.getByTestId('icon-check-mark')).toBeInTheDocument();

expect(await screen.findByTestId('icon-check-mark')).toBeInTheDocument();

expect(screen.getByRole('button', {name: 'Preview File'})).toHaveAttribute(
'href',
Expand All @@ -117,11 +117,11 @@ describe('AddCodeOwnerModal', () => {
/>
);

await waitFor(() =>
selectEvent.select(
screen.getByText('--'),
`Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`
)
await userEvent.click(await screen.findByRole('textbox'));
await userEvent.click(
await screen.findByRole('menuitemradio', {
name: `Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`,
})
);

expect(screen.getByText('No codeowner file found.')).toBeInTheDocument();
Expand Down Expand Up @@ -153,13 +153,17 @@ describe('AddCodeOwnerModal', () => {
project={project}
/>
);
await waitFor(() =>
selectEvent.select(
screen.getByText('--'),
`Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`
)

await userEvent.click(await screen.findByRole('textbox'));
await userEvent.click(
await screen.findByRole('menuitemradio', {
name: `Repo Name: ${codeMapping.repoName}, Stack Trace Root: ${codeMapping.stackRoot}, Source Code Root: ${codeMapping.sourceRoot}`,
})
);

await waitFor(() => {
expect(screen.getByRole('button', {name: 'Add File'})).toBeEnabled();
});
await userEvent.click(screen.getByRole('button', {name: 'Add File'}));

await waitFor(() => {
Expand Down
Loading
Loading