ref(lint): no-non-null-assertion in scraps#115165
Merged
Merged
Conversation
Collaborator
Author
|
bugbot run |
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.49% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a1540a. Configure here.
Comment on lines
+241
to
+244
| for (let j = startingIndex; j < item.options.length; j++) { | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| hiddenOptionsSet.add(item.options[j]!.key); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| for (let j = startingIndex; j < item.options.length; j++) { | |
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |
| hiddenOptionsSet.add(item.options[j]!.key); | |
| } | |
| for (const option of item.options.slice(startingIndex)) { | |
| hiddenOptionsSet.add(option.key); | |
| } |
Comment on lines
177
to
178
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| let initials = Array.from(words[0]!)[0]!; |
Member
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |
| let initials = Array.from(words[0]!)[0]!; | |
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |
| let initials = Array.from(words[0] ?? '')[0] ?? ''; |
Comment on lines
180
to
181
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| initials += Array.from(words[words.length - 1]!)[0]!; |
Member
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |
| initials += Array.from(words[words.length - 1]!)[0]!; | |
| initials += Array.from(words[words.length - 1] ?? '')[0] ?? ''; |
Comment on lines
+262
to
263
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| return value!; |
Member
There was a problem hiding this comment.
hm can't we do something like?
if (value === undefined) {
Sentry.captureMessage('useResponsivePropValue: no defined breakpoint resolved', {
extra: {prop},
});
return undefined as ResponsiveValue<T>;
}
return value;
Collaborator
Author
There was a problem hiding this comment.
I think this is fine as-is, but I addressed your other findings 🙏
Member
|
Can't wait for this to land 🎉 I'm not a fan of |
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
enable the `no-non-null-assertion` eslint rule for `scraps`. Note: I’ve ignored test files because 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable the
no-non-null-assertioneslint rule forscraps.Note: I’ve ignored test files because 🤷