chore(iswf): Removes retry decorators from integration-related tasks#115028
Merged
GabeVillalobos merged 3 commits intomasterfrom May 7, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
| name="sentry.integrations.github.tasks.codecov_account_unlink", | ||
| namespace=integrations_control_tasks, | ||
| retry=Retry(times=3), | ||
| retry=Retry(times=3, on=(Exception,), ignore=(ConfigurationError,)), |
Contributor
There was a problem hiding this comment.
Seems a bit odd that the decorator needs to specify what to retry on ? Versus just saying what to ignore and then retry on everything else... Curious what was the why there?
Member
Author
There was a problem hiding this comment.
The older decorator did the same thing, it just set a default of (Exception,). We've opted to make this more explicit now, since this makes it instantly clear what the Retry is and isn't doing, though I do see your point.
Christinarlong
approved these changes
May 7, 2026
GabeVillalobos
deleted the
gv/remove-retry-decorators-from-integration-tasks
branch
constantinius
pushed a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work of #114937, this PR removes more of the old
@retrydecorators from tasks, updating them to their closest equivalent in Taskbroker.