Skip to content

chore(alerts): Remove NeglectedRule model#114927

Merged
ceorourke merged 4 commits intomasterfrom
ceorourke/rm-neglectedrule-model
May 6, 2026
Merged

chore(alerts): Remove NeglectedRule model#114927
ceorourke merged 4 commits intomasterfrom
ceorourke/rm-neglectedrule-model

Conversation

@ceorourke
Copy link
Copy Markdown
Member

Remove FK constraints and the NeglectedRule table itself. Final PR will be to actually remove the table from Postgres.

@ceorourke ceorourke requested review from a team as code owners May 5, 2026 22:45
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

This PR has a migration; here is the generated SQL for src/sentry/migrations/1081_remove_neglectedrule.py

for 1081_remove_neglectedrule in sentry

--
-- Alter field organization on neglectedrule
--
SET CONSTRAINTS "sentry_neglectedrule_organization_id_5dfb1f9b_fk_sentry_or" IMMEDIATE; ALTER TABLE "sentry_neglectedrule" DROP CONSTRAINT "sentry_neglectedrule_organization_id_5dfb1f9b_fk_sentry_or";
--
-- Alter field rule on neglectedrule
--
SET CONSTRAINTS "sentry_neglectedrule_rule_id_c4356e45_fk_sentry_rule_id" IMMEDIATE; ALTER TABLE "sentry_neglectedrule" DROP CONSTRAINT "sentry_neglectedrule_rule_id_c4356e45_fk_sentry_rule_id";
--
-- Moved model NeglectedRule to pending deletion state
--
-- (no-op)

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9ef43b3. Configure here.

Comment thread src/sentry/testutils/helpers/backups.py
Copy link
Copy Markdown
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration lgtm, looks like there are still a couple of references to remove

@ceorourke ceorourke merged commit b572d39 into master May 6, 2026
82 of 83 checks passed
@ceorourke ceorourke deleted the ceorourke/rm-neglectedrule-model branch May 6, 2026 16:04
ceorourke added a commit that referenced this pull request May 6, 2026
Follow up to #114927 to remove
the table from Postgres.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants