prototype(logs): Add row pinning to logs explorer#114922
Draft
marthalyndon wants to merge 1 commit intomasterfrom
Draft
prototype(logs): Add row pinning to logs explorer#114922marthalyndon wants to merge 1 commit intomasterfrom
marthalyndon wants to merge 1 commit intomasterfrom
Conversation
Add the ability to pin log rows in the logs explorer table. Pinned rows appear in a collapsible section at the top of the table while remaining visible in the chronological list. Hovering any copy highlights all instances via a shared hover context. Pins persist in the URL for shareability. Key implementation details: - New `organizations:ourlogs-pinning` feature flag - Context-based state with URL sync via replaceState (avoids React Router re-renders) - Pinned/chronological rows use independent expand keys so expanding one copy doesn't expand the other - Pin button appears on row hover next to the existing ellipsis menu - "Clear all" button and collapse/expand toggle in the pinned section divider
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[POC prototype from Design]
Add the ability to pin log rows in the logs explorer table. Pinned rows appear in a collapsible section at the top of the table while remaining visible in the chronological list. Hovering any copy highlights all instances via a shared hover context. Pins persist in the URL for shareability.
Key implementation details:
organizations:ourlogs-pinningfeature flag