feat(dashboards): Create HeatMapWidgetVisualization component#114916
Draft
feat(dashboards): Create HeatMapWidgetVisualization component#114916
Conversation
This prop was passed in, but never actually given to ECharts, so it was pointless!
Fix Zstep range calculation (was Zmin+Zmax, should be Zmax-Zmin), remove duplicate PlottableTimeSeriesValueType from heatMap.tsx, and remove unused LOADING_PLACEHOLDER export from settings. Refs LOGS-762 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
These files aren't consumed by any production entry point yet. Add a temporary knip entry point exception until the widget is integrated into Explore. Refs LOGS-762 Co-Authored-By: Claude <noreply@anthropic.com>
HeatMapValueType is only used internally within types.tsx, so it doesn't need to be exported. Fixes knip unused-export violation. Refs LOGS-762 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before having Heat Map support in Explore, one must have a Heat Map component to put into Explore! This is that widget. This is an MVP, it doesn't even have any features aside from plotting that mostly works. What it does have is:
e.g.,
This component follows a very similar structure to how the time series, and categorical visualization widgets work. They declare a
Plottableinterface that the visualization component can plot, and each plottable kind (in this case, justHeatMap) works against that interface. There's a decent chance that we'll support other heat map plottables if we want to show percentiles on the same chart.This is working from @marthalyndon's generous #114616 which spiked this feature a while back. Thank you Martha!
I also had to update
BaseChartbecause it was dropping itsvisualMapprop on the floor mysteriously!The
BaseChartcomponent is extended with avisualMapprop passthrough since ECharts heat maps require a visual map for color mapping. TheHeatMapPlottableinterface is intentionally separate from the existingPlottableinterface since heat maps have fundamentally different axes (X, Y, Z) compared to time series (X, Y).Closes LOGS-762