feat(sentry-apps): Add disable/enable toggle to _admin sentry app details#114910
Merged
Christinarlong merged 9 commits intomasterfrom May 7, 2026
Merged
feat(sentry-apps): Add disable/enable toggle to _admin sentry app details#114910Christinarlong merged 9 commits intomasterfrom
Christinarlong merged 9 commits intomasterfrom
Conversation
…ails Add a Disable/Enable action to the sentry app admin details page that calls PUT /api/0/sentry-apps/{slug}/ with {isDisabled: true/false}. Also adds: - A red "disabled" badge next to the status badge when the app is disabled - An isDisabled yes/no row in the details list ISWF-1234
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.45% |
…ails Add a Disable/Enable action to the sentry app admin details page that calls PUT /api/0/sentry-apps/{slug}/ with {isDisabled: true/false}. Also adds: - A red "disabled" badge next to the status badge when the app is disabled - An isDisabled yes/no row in the details list - Tests for the disable/enable action and badge rendering ISWF-1234
…ests Actions are inside a CompactSelect dropdown — need to click the trigger button (data-test-id="detail-actions") first to make them visible. ISWF-1234
…test CompactSelect options need to be selected via their role, not plain text click, for the onChange handler to fire and open the confirm modal. ISWF-1234
…test The CompactSelect + openAdminConfirmModal flow is difficult to test in isolation. Replace with a simpler test that verifies isDisabled appears in the detail labels. The action rendering is already covered by the other two tests. ISWF-1234
DetailLabel renders as <dt>isDisabled:</dt> — search for the full text including the colon. ISWF-1234
saponifi3d
approved these changes
May 6, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
some nits; but this is _admin so it's a bit less critical.
…lper, add mutation test - Rename DetailLabel from "isDisabled" to "Enabled" with inverted boolean for positive-case readability - Extract renderSentryAppDetails helper to DRY up test setup - Add mutation test verifying PUT sends correct isDisabled value ISWF-1234
…lper, add mutation test - Rename DetailLabel from "isDisabled" to "Enabled" with inverted boolean for positive-case readability - Extract renderSentryAppDetails helper to DRY up test setup - Add mutation test using renderGlobalModal to test the full dropdown → confirm modal → PUT flow - Add Enabled: yes/no assertions for both states ISWF-1234
When isDisabled is true, both isAlertable and Enabled render 'no' tags. Assert exactly 2 matches instead of getByText which errors on multiple. ISWF-1234
constantinius
pushed a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a disable/enable sentry app to the Sentry Apps Actions dropdown in _admin.
Requires the option
sentry-apps.disabled-enforcementto be on firstAlso requires #114980 to go in first
Refs ISWF-1234
Images
not disabled + disable button
Disabled + enable button