feat(dashboards): Add All Dashboards tab and rename existing to Custom#114904
Open
DominikB2014 wants to merge 4 commits intomasterfrom
Open
feat(dashboards): Add All Dashboards tab and rename existing to Custom#114904DominikB2014 wants to merge 4 commits intomasterfrom
DominikB2014 wants to merge 4 commits intomasterfrom
Conversation
…ustom When `dashboards-prebuilt-insights-dashboards` is enabled, the secondary navigation now shows three tabs: - All Dashboards (`?filter=all`): combined view of custom + prebuilt - Custom Dashboards: the existing no-filter view, renamed from "All Dashboards" - Sentry Built (`?filter=onlyPrebuilt`): unchanged The primary sidebar still lands on Custom Dashboards (the no-filter URL) to preserve existing behavior; the new All tab is opt-in via the secondary nav. DAIN-1637
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
…f prebuilt The vast majority of orgs have the prebuilt dashboards feature enabled, so the per-org label split adds noise without helping the rare non-prebuilt case.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f362935. Configure here.
…b enum Replace the ad-hoc isOnlyPrebuilt/isAllDashboards booleans with a single DashboardsTab state derived from the URL filter, plus mapping tables for the page title and API query params. The mutually exclusive boolean states made the filter logic harder to follow and easier to break with a new tab.
Add an "All Dashboards" entry that links to ?filter=all when prebuilt dashboards are enabled, and rename the no-filter entry to "Custom Dashboards" so it matches the secondary nav after the recent split.
gggritso
approved these changes
May 5, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
LGTM, just some nits. This might work a bit better if we had separate URLs for these filters, but not a big deal 👍🏻
| )} | ||
| <CMDKAction | ||
| display={{label: t('All Dashboards')}} | ||
| display={{label: t('Custom Dashboards')}} |
Member
There was a problem hiding this comment.
Maybe a bit more precise here to do something like
Suggested change
| display={{label: t('Custom Dashboards')}} | |
| display={{label: hasPrebuiltDashboards ? t('Custom Dashboards') : t ('All Dashboards')}} |
| analyticsItemName="dashboards_all" | ||
| > | ||
| {t('All Dashboards')} | ||
| {t('Custom Dashboards')} |
Member
There was a problem hiding this comment.
Same note as above, I think if someone doesn't have pre-built dashboards it should continue to say "All Dashboards", but not a big deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
all dashboardsandcustom dashboardsoption when prebuilt dashboards are enabled,custom dashboardsis retained as the default.