Skip to content

feat(logs): Move continue scanning into full button #112351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsdeschenes merged 9 commits into from
Apr 7, 2026
Merged

feat(logs): Move continue scanning into full button #112351

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47938a5
Update icon color to be accent
nsdeschenes Apr 1, 2026
5be5214
Update styles for EmptyStateText
nsdeschenes Apr 1, 2026
a72c3c9
Update EmptyRenderer to new copy
nsdeschenes Apr 1, 2026
58606a3
fix(logs): Scope empty state icon accent styling
nsdeschenes Apr 7, 2026
a7ab716
ref(explore): Use align prop for traces table text
nsdeschenes Apr 7, 2026
3678ef9
fix(explore): Restore muted empty state text
nsdeschenes Apr 7, 2026
891c2d8
Add period to empty state string
nsdeschenes Apr 7, 2026
b366fc5
Create explicit icon variant type, and export it
nsdeschenes Apr 7, 2026
958146d
fix(explore): Render empty state text as a block element
nsdeschenes Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/components/emptyStateWarning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ export function EmptyStateWarning({
return small ? (
<EmptyMessage className={className}>
<SmallMessage>
{withIcon && <StyledIconSearch variant="muted" size="lg" />}
{withIcon && <StyledIconSearch variant="accent" size="lg" />}
{children}
</SmallMessage>
</EmptyMessage>
) : (
<EmptyStreamWrapper data-test-id="empty-state" className={className}>
{withIcon && <IconSearch variant="muted" legacySize="54px" />}
{withIcon && <IconSearch variant="accent" legacySize="54px" />}
Comment thread
nsdeschenes marked this conversation as resolved.
Outdated
{children}
</EmptyStreamWrapper>
);
Expand Down
30 changes: 15 additions & 15 deletions static/app/views/explore/logs/tables/logsInfiniteTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {Virtualizer} from '@tanstack/react-virtual';
import {useVirtualizer, useWindowVirtualizer} from '@tanstack/react-virtual';

import {Button} from '@sentry/scraps/button';
import {Flex, Stack} from '@sentry/scraps/layout';
import {Container, Flex, Stack} from '@sentry/scraps/layout';
import {ExternalLink} from '@sentry/scraps/link';
import {Tooltip} from '@sentry/scraps/tooltip';

Expand Down Expand Up @@ -666,22 +666,22 @@ function EmptyRenderer({
<EmptyStateText size="xl">{t('No logs found yet')}</EmptyStateText>
<EmptyStateText size="md">
{tct(
'We scanned [bytesScanned] already but did not find any matching logs yet.[break]You can narrow your time range or you can [continueScanning].',
{
bytesScanned: <FileSize bytes={bytesScanned} base={2} />,
break: <br />,
continueScanning: (
<Button
priority="link"
onClick={resumeAutoFetch}
aria-label={t('continue scanning')}
>
{t('Continue Scanning')}
</Button>
),
}
'We scanned [bytesScanned] so far but have not found anything matching your filters',
{bytesScanned: <FileSize bytes={bytesScanned} base={2} />}
)}
</EmptyStateText>
<EmptyStateText size="md">
{t('We can keep digging or you can narrow down your search.')}
Comment thread
nsdeschenes marked this conversation as resolved.
</EmptyStateText>
<Container paddingTop="md">
<Button
priority="default"
onClick={resumeAutoFetch}
aria-label={t('continue scanning')}
>
{t('Continue Scanning')}
</Button>
</Container>
</EmptyStateWarning>
</TableStatus>
);
Expand Down
24 changes: 16 additions & 8 deletions static/app/views/explore/tables/tracesTable/styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type {ComponentProps, CSSProperties} from 'react';
import {css} from '@emotion/react';
import styled from '@emotion/styled';

import {Flex} from '@sentry/scraps/layout';
import {Container, Flex} from '@sentry/scraps/layout';
import {Text} from '@sentry/scraps/text';

import {Panel} from 'sentry/components/panels/panel';
Expand Down Expand Up @@ -123,15 +123,23 @@ export const BreakdownPanelItem = styled(StyledPanelItem)<{highlightedSliceName:
`}
`;

export const EmptyStateText = styled('div')<{
export function EmptyStateText({
children,
size,
textAlign,
}: {
children: React.ReactNode;
size: 'xl' | 'md';
textAlign?: CSSProperties['textAlign'];
}>`
color: ${p => p.theme.tokens.content.secondary};
font-size: ${p => p.theme.font.size[p.size]};
padding-bottom: ${p => p.theme.space.md};
${p => p.textAlign && `text-align: ${p.textAlign}`};
`;
}) {

@JoshuaKGoldberg JoshuaKGoldberg Apr 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Praise] Nice use of the design system 🙂 I like this!

return (
<Container>
<Text size={size} style={{textAlign}}>
Comment thread
nsdeschenes marked this conversation as resolved.
Outdated
Comment thread
nsdeschenes marked this conversation as resolved.
Outdated
{children}
</Text>
Comment thread
cursor[bot] marked this conversation as resolved.
</Container>
);
}
Comment thread
nsdeschenes marked this conversation as resolved.

export const EmptyValueContainer = styled('span')`
color: ${p => p.theme.tokens.content.secondary};
Expand Down
Loading