Skip to content

ref(preprod): Add organization_slug to size analysis log #112194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 2 commits into from
Apr 7, 2026
+1 −0
Merged

ref(preprod): Add organization_slug to size analysis log #112194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a6ca98
ref(preprod): Add organization_slug to size analysis log
NicoHinderling Apr 3, 2026
d6d4a12
ref(preprod): Use in-scope organization variable instead of project.o…
NicoHinderling Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/preprod/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@
"was_created": was_created,
"project_id": project.id,
"organization_id": org_id,
"organization_slug": organization.slug,

Check warning on line 565 in src/sentry/preprod/tasks.py

View check run for this annotation

@sentry/warden / warden: sentry-backend-bugs

NameError when accessing organization.slug if EAP block fails early 

Line 565 accesses `organization.slug`, but `organization` is only defined inside the try block at line 513. If that line or any code before line 513 throws an exception, the except block at line 530 catches and logs it without re-raising, allowing execution to continue to line 565. At that point, `organization` is undefined, causing `NameError: name 'organization' is not defined`. This will convert a non-fatal EAP write failure into a fatal task error.
Comment thread
cursor[bot] marked this conversation as resolved.
},
)

Expand Down
Loading