Skip to content

feat(dashboards): Add ESC key to dismiss widget builder slideout #112186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 5 commits into from
Apr 7, 2026
Merged

feat(dashboards): Add ESC key to dismiss widget builder slideout #112186

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa48899
feat(dashboards): Add ESC key to dismiss widget builder slideout
NicoHinderling Apr 2, 2026
0373efb
fix(dashboards): Skip ESC handler when confirmation modal is open
NicoHinderling Apr 2, 2026
cab9f4f
ref(dashboards): Use useHotkeys for ESC key handling in widget builder
NicoHinderling Apr 7, 2026
8dd2884
fix(dashboards): Restore missing useEffect import in widget builder
NicoHinderling Apr 7, 2026
ac660ef
fix(dashboards): Prevent ESC from blocking confirmation modal dismiss
NicoHinderling Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,16 @@ export function WidgetBuilderSlideout({
});
}, [initialState, onClose, state]);

useEffect(() => {

@scttcper scttcper Apr 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably copy what we're doing here https://github.com/getsentry/sentry/blob/master/static/app/components/globalDrawer/index.tsx#L187-L196

function handleKeyDown(event: KeyboardEvent) {
if (event.key === 'Escape') {
onCloseWithModal();
}
}
document.addEventListener('keydown', handleKeyDown);
return () => document.removeEventListener('keydown', handleKeyDown);
}, [onCloseWithModal]);
Comment thread
sentry[bot] marked this conversation as resolved.
Outdated
Comment thread
NicoHinderling marked this conversation as resolved.
Outdated

const breadcrumbs = customizeFromLibrary
? [
{
Expand Down
Loading