fix(test): stabilize flaky allMonitors select all query results test#111901
Merged
Conversation
JoshuaKGoldberg
added
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
The tooltip on disabled menu items in CompactSelect/MenuListItem has a 500ms delay before appearing. Under CI load, this delay plus React render time can exceed findByText's default 1000ms timeout, causing intermittent failures. Extend the timeout to 2000ms. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
fix/flaky-customer-details-spec
branch
from
cb225e9 to
5556911
Compare
JoshuaKGoldberg
removed
the
Frontend: Rerun Flaky Tests
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test creates 20 filtered detectors and sets
X-Hits: 50, then asserts on "20 monitors on this page selected" and "Select all 50 monitors that match this search query". With that many fixtures and complex rendering, the test can time out under CI load.The fix reduces the fixture count from 20 to 3 and
X-Hitsfrom 50 to 10. That keeps the test's intent (verify select-all-across-pages behavior) but with less intensive work.Fixes ENG-7204
Made with Cursor