Skip to content

fix(performance): Restore feature parity on EAP Sampled Events tab #111731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjq wants to merge 20 commits into from
Closed

fix(performance): Restore feature parity on EAP Sampled Events tab #111731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
51ab204
ref(perf): Remove category filter from EAP sampled events table
mjq Mar 24, 2026
671e36e
ref(perf): Decouple OverviewSpansTable from shared segment spans query
mjq Mar 25, 2026
d1d8306
feat(perf): Enable column sorting in EAP sampled events table
mjq Mar 25, 2026
dbf9fce
ref(perf): Conditionally show Replay column in EAP sampled events table
mjq Mar 25, 2026
c0536ca
feat(perf): Link trace ID to trace details in EAP sampled events table
mjq Mar 25, 2026
1559543
feat(perf): Add HTTP Method column to EAP sampled events table
mjq Mar 25, 2026
f6bba2f
feat(perf): Add User column to EAP sampled events table
mjq Mar 26, 2026
dbe22f5
ref(perf): Reorder columns in EAP sampled events table
mjq Mar 26, 2026
f6a5806
add operation duration column
mjq Mar 26, 2026
da0689e
feat(perf): Add Open in Explore button to EAP sampled events table
mjq Mar 26, 2026
9daa62b
feat(perf): Add Percentile dropdown to EAP sampled events table
mjq Mar 27, 2026
f5132bb
fix(perf): Clamp negative otherPercentage in operation duration break…
mjq Mar 27, 2026
afeec90
ref(perf): Rename OverviewSpansTable to SampledEventsTable
mjq Mar 27, 2026
5949ea7
fix(perf): Fix project lookup when multiple projects selected
mjq Mar 27, 2026
c3f0ea2
fix(perf): Preserve date context in trace links from sampled events t…
mjq Mar 27, 2026
d98a5ac
ref(performance): De-slop EAP version of Sampled Events
mjq Mar 30, 2026
72cf046
move percentile value mapping out of utils
mjq Mar 31, 2026
e9056fa
make request.method column conditional on project type
mjq Mar 31, 2026
80085a4
add test confirming switch via eap flag
mjq Mar 31, 2026
75fe46e
add smoke tests for new EAP components
mjq Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions static/app/views/insights/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ export enum SpanFields {
AI_TOTAL_COST = 'ai.total_cost',
AI_TOTAL_TOKENS_USED = 'ai.total_tokens.used',

// Span Operation Breakdown fields
SPANS_BROWSER = 'spans.browser',
SPANS_DB = 'spans.db',
SPANS_HTTP = 'spans.http',
SPANS_RESOURCE = 'spans.resource',
SPANS_UI = 'spans.ui',

// DB fields
DB_SYSTEM = 'db.system', // TODO: this is a duplicate of `SPAN_SYSTEM`

Expand Down
217 changes: 0 additions & 217 deletions static/app/views/performance/eap/overviewSpansTable.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion static/app/views/performance/eap/segmentSpansTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function SegmentSpansTable({
const {projects} = useProjects();
const navigate = useNavigate();

const projectSlug = projects.find(p => p.id === `${eventView.project}`)?.slug;
const projectSlug = projects.find(p => p.id === String(eventView.project[0]))?.slug;
const spanCategory = decodeScalar(location.query?.[SpanFields.SPAN_CATEGORY]);
const {selected, options} = getEAPSegmentSpansListSort(location, spanCategory);

Expand Down
Loading
Loading