Skip to content

feat(notifications): Add notification data and renderer for metric alerts#111674

Merged
Christinarlong merged 16 commits into
masterfrom
crl/meetric-alert-data
Mar 30, 2026
Merged

feat(notifications): Add notification data and renderer for metric alerts#111674
Christinarlong merged 16 commits into
masterfrom
crl/meetric-alert-data

Merge branch 'master' into crl/meetric-alert-data

dc5aefb
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Mar 30, 2026 in 3m 30s

1 issue

Medium

Activity.objects.get() missing DoesNotExist handler causes notification failures - `src/sentry/notifications/platform/slack/renderers/metric_alert.py:51`

The Activity.objects.get(id=data.activity_id) call has no exception handling. When an activity is deleted between notification creation and rendering, this raises Activity.DoesNotExist. The notification will fail silently and create a Sentry issue.

Also found at:

  • src/sentry/notifications/platform/slack/renderers/metric_alert.py:52
  • src/sentry/notifications/platform/slack/renderers/metric_alert.py:72
2 skills analyzed
Skill Findings Duration Cost
sentry-security 0 2m 14s $2.19
sentry-backend-bugs 1 3m 22s $1.47

Duration: 5m 36s · Tokens: 2.8M in / 33.1k out · Cost: $3.68 (+extraction: $0.00, +merge: $0.00, +dedup: $0.01)