[Reference] test: arbitrary changes to 15 medium-connected source+test files#111630
Closed
JoshuaKGoldberg wants to merge 5 commits into
Closed
[Reference] test: arbitrary changes to 15 medium-connected source+test files#111630JoshuaKGoldberg wants to merge 5 commits into
JoshuaKGoldberg wants to merge 5 commits into
Conversation
Made-with: Cursor
The git diff for the non-frontend file guard was comparing against HEAD (the synthetic merge commit) instead of HEAD^2 (the PR branch tip). This included base branch changes in the diff, causing false positives that unnecessarily forced full test runs. Made-with: Cursor
14d8c0e to
5c9ae7e
Compare
081fdc7 to
f9ba9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference PR for testing
--changedSincewith 15 medium-connectivity source+test pairs. See #110568.Made with Cursor