fix(project-creation): Rollback when rules fail to be created #103208
+179
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ArthurKnaus
reviewed
Nov 12, 2025
| return {project, notificationRule, ruleIds}; | ||
| } catch (error) { | ||
| // Attach project for rollback | ||
| (error as RequestError & {createdProject: Project}).createdProject = project; |
Member
There was a problem hiding this comment.
hmmm, I would prefer a type safe alternative. Why are we not doing the rollback in this hook where we have all the information?
Member
Author
There was a problem hiding this comment.
do you mean the rollback right here or inside of the onError of this hook?
Member
There was a problem hiding this comment.
yes.
for me it would make sense as it is the responsibility of the hook to orchestrate those two requests. As soon as we do it outside the hook, we actually need knowledge about its internals.
Member
Author
There was a problem hiding this comment.
yes it makes sense. will update the code! thank you
…n-rules-fail-to-be-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/TET-1369/user-confusion-when-project-creation-fails-but-succeeds
Example (after the fix):
Screen.Recording.2025-11-12.at.07.04.16.mov