Skip to content

Commit d444796

Browse files
fix(pageframe): Move flex={1} into DetailLayout component
DetailLayoutComponent only accepts children in its props interface, so flex cannot be passed from call sites. Add flex={1} directly on the StyledPage inside the component instead. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ded09ab commit d444796

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

static/app/components/workflowEngine/layout/detail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ interface WorkflowEngineDetailLayoutProps {
2020
* Precomposed 67/33 layout for Monitors / Alerts detail pages.
2121
*/
2222
function DetailLayoutComponent({children}: WorkflowEngineDetailLayoutProps) {
23-
return <StyledPage>{children}</StyledPage>;
23+
return <StyledPage flex={1}>{children}</StyledPage>;
2424
}
2525

2626
const StyledPage = styled(Stack)`

static/app/views/automations/detail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function AutomationDetailContent({automation}: {automation: Automation}) {
5656

5757
return (
5858
<SentryDocumentTitle title={automation.name}>
59-
<DetailLayout flex={1}>
59+
<DetailLayout>
6060
<DetailLayout.Header>
6161
<DetailLayout.HeaderContent>
6262
<Breadcrumbs

static/app/views/detectors/components/details/cron/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export function CronDetectorDetails({detector, project}: CronDetectorDetailsProp
156156

157157
return (
158158
<TimezoneProvider timezone={timezoneOverride}>
159-
<DetailLayout flex={1}>
159+
<DetailLayout>
160160
<DetectorDetailsHeader detector={detector} project={project} />
161161
<DetailLayout.Body>
162162
<DetailLayout.Main>

static/app/views/detectors/components/details/error/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export function ErrorDetectorDetails({detector, project}: ErrorDetectorDetailsPr
7474
const {selection} = usePageFilters();
7575

7676
return (
77-
<DetailLayout flex={1}>
77+
<DetailLayout>
7878
<DetailLayout.Header>
7979
<DetectorDetailsDefaultHeaderContent detector={detector} project={project} />
8080
<DetailLayout.Actions>

static/app/views/detectors/components/details/fallback.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function FallbackDetectorDetails({
1818
project,
1919
}: FallbackDetectorDetailsProps) {
2020
return (
21-
<DetailLayout flex={1}>
21+
<DetailLayout>
2222
<DetectorDetailsHeader detector={detector} project={project} />
2323
<DetailLayout.Body>
2424
<DetailLayout.Main>

static/app/views/detectors/components/details/metric/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export function MetricDetectorDetails({detector, project}: MetricDetectorDetails
4141
const intervalSeconds = dataSource.queryObj?.snubaQuery.timeWindow;
4242

4343
return (
44-
<DetailLayout flex={1}>
44+
<DetailLayout>
4545
<DetectorDetailsHeader detector={detector} project={project} />
4646
<DetailLayout.Body>
4747
<DetailLayout.Main>

static/app/views/detectors/components/details/mobileBuild/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export function MobileBuildDetectorDetails({
1919
project,
2020
}: MobileBuildDetectorDetailsProps) {
2121
return (
22-
<DetailLayout flex={1}>
22+
<DetailLayout>
2323
<DetectorDetailsHeader detector={detector} project={project} />
2424
<DetailLayout.Body>
2525
<DetailLayout.Main>

static/app/views/detectors/components/details/uptime/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export function UptimeDetectorDetails({detector, project}: UptimeDetectorDetails
5757
}, []);
5858

5959
return (
60-
<DetailLayout flex={1}>
60+
<DetailLayout>
6161
<DetectorDetailsHeader detector={detector} project={project} />
6262
<DetailLayout.Body>
6363
<DetailLayout.Main>

0 commit comments

Comments
 (0)