Skip to content

Commit ded09ab

Browse files
ref(pageframe): Address remaining review comments
- Add conditional secondary background to createFromSeerPrompt, only applying it when page-frame feature is not enabled. - Preserve title prop on pullRequestDetails Stack, restoring the HTML title attribute that Layout.Page previously provided. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent a6aa998 commit ded09ab

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

static/app/views/dashboards/createFromSeerPrompt.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@ import {normalizeUrl} from 'sentry/utils/url/normalizeUrl';
1313
import {useLocation} from 'sentry/utils/useLocation';
1414
import {useNavigate} from 'sentry/utils/useNavigate';
1515
import {useOrganization} from 'sentry/utils/useOrganization';
16+
import {useHasPageFrameFeature} from 'sentry/views/navigation/useHasPageFrameFeature';
1617

1718
export function CreateFromSeerPrompt() {
1819
const organization = useOrganization();
1920
const location = useLocation();
2021
const navigate = useNavigate();
2122
const [prompt, setPrompt] = useState('');
2223
const [isGenerating, setIsGenerating] = useState(false);
24+
const hasPageFrame = useHasPageFrameFeature();
2325

2426
const handleGenerate = useCallback(async () => {
2527
if (!prompt.trim()) {
@@ -60,7 +62,7 @@ export function CreateFromSeerPrompt() {
6062
}, [prompt, organization.slug, location.query, navigate]);
6163

6264
return (
63-
<Stack flex={1} padding="2xl 3xl">
65+
<Stack flex={1} padding="2xl 3xl" background={hasPageFrame ? undefined : 'secondary'}>
6466
<Flex direction="column" gap="lg" align="center" justify="center" flex="1">
6567
<Flex direction="column" gap="sm" width="640px">
6668
<Heading as="h3">{t('Describe your Dashboard')}</Heading>

static/app/views/pullRequest/details/pullRequestDetails.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,10 @@ export default function PullRequestDetails() {
105105
}
106106

107107
return (
108-
<Stack flex={1}>
108+
<Stack
109+
flex={1}
110+
title={`#${prSuccessData.pull_request.number}: ${prSuccessData.pull_request.title}`}
111+
>
109112
<Layout.Header>
110113
<PullRequestDetailsHeaderContent pullRequest={prSuccessData} />
111114
<Layout.HeaderTabs value={selectedTab || 'files'} onChange={setSelectedTab}>

0 commit comments

Comments
 (0)