Skip to content

Commit 1b29093

Browse files
fix(layout): move Layout.Page to conversations layout
Move Layout.Page from the overview page component to the layout component so it wraps both the header and the outlet. This ensures Layout.Header is a direct child of Layout.Page, giving it the correct border-radius and framed appearance.
1 parent bb00c17 commit 1b29093

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

static/app/views/insights/pages/conversations/layout.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
import {Fragment} from 'react';
21
import {Outlet, useMatches} from 'react-router-dom';
32

3+
import * as Layout from 'sentry/components/layouts/thirds';
44
import {ConversationsPageHeader} from 'sentry/views/insights/pages/conversations/conversationsPageHeader';
55
import {ModuleName} from 'sentry/views/insights/types';
66

77
function ConversationsLayout() {
88
const handle = useMatches().at(-1)?.handle as {module?: ModuleName} | undefined;
99

1010
return (
11-
<Fragment>
11+
<Layout.Page>
1212
{handle && 'module' in handle ? (
1313
<ConversationsPageHeader module={handle.module} />
1414
) : null}
1515
<Outlet />
16-
</Fragment>
16+
</Layout.Page>
1717
);
1818
}
1919

static/app/views/insights/pages/conversations/overview.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,9 @@ function PageWithProviders() {
201201
});
202202

203203
return (
204-
<Layout.Page>
205-
<DomainOverviewPageProviders maxPickableDays={datePageFilterProps.maxPickableDays}>
206-
<ConversationsOverviewPage datePageFilterProps={datePageFilterProps} />
207-
</DomainOverviewPageProviders>
208-
</Layout.Page>
204+
<DomainOverviewPageProviders maxPickableDays={datePageFilterProps.maxPickableDays}>
205+
<ConversationsOverviewPage datePageFilterProps={datePageFilterProps} />
206+
</DomainOverviewPageProviders>
209207
);
210208
}
211209

0 commit comments

Comments
 (0)