Skip to content

Commit bb00c17

Browse files
committed
ref(layout): use Layout.Page on isolated pages
Wraps non-compliant routes in isolated page areas with Layout.Page. Part of the Layout.Page audit remediation.
1 parent e675594 commit bb00c17

4 files changed

Lines changed: 37 additions & 27 deletions

File tree

static/app/views/insights/pages/conversations/overview.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,11 @@ function PageWithProviders() {
201201
});
202202

203203
return (
204-
<DomainOverviewPageProviders maxPickableDays={datePageFilterProps.maxPickableDays}>
205-
<ConversationsOverviewPage datePageFilterProps={datePageFilterProps} />
206-
</DomainOverviewPageProviders>
204+
<Layout.Page>
205+
<DomainOverviewPageProviders maxPickableDays={datePageFilterProps.maxPickableDays}>
206+
<ConversationsOverviewPage datePageFilterProps={datePageFilterProps} />
207+
</DomainOverviewPageProviders>
208+
</Layout.Page>
207209
);
208210
}
209211

static/app/views/profiling/differentialFlamegraph.tsx

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {vec2} from 'gl-matrix';
66

77
import {addErrorMessage} from 'sentry/actionCreators/indicator';
88
import Feature from 'sentry/components/acl/feature';
9+
import * as Layout from 'sentry/components/layouts/thirds';
910
import {usePageFilters} from 'sentry/components/pageFilters/usePageFilters';
1011
import {DifferentialFlamegraphLayout} from 'sentry/components/profiling/flamegraph/differentialFlamegraphLayout';
1112
import {FlamegraphContextMenu} from 'sentry/components/profiling/flamegraph/flamegraphContextMenu';
@@ -356,18 +357,20 @@ const DifferentialFlamegraphContainer = styled('div')`
356357

357358
function DifferentialFlamegraphWithProviders() {
358359
return (
359-
<FlamegraphThemeProvider>
360-
<FlamegraphStateProvider
361-
initialState={{
362-
preferences: {
363-
sorting: 'alphabetical',
364-
view: 'top down',
365-
},
366-
}}
367-
>
368-
<DifferentialFlamegraphView />
369-
</FlamegraphStateProvider>
370-
</FlamegraphThemeProvider>
360+
<Layout.Page>
361+
<FlamegraphThemeProvider>
362+
<FlamegraphStateProvider
363+
initialState={{
364+
preferences: {
365+
sorting: 'alphabetical',
366+
view: 'top down',
367+
},
368+
}}
369+
>
370+
<DifferentialFlamegraphView />
371+
</FlamegraphStateProvider>
372+
</FlamegraphThemeProvider>
373+
</Layout.Page>
371374
);
372375
}
373376

static/app/views/profiling/profileSummary/index.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -781,10 +781,12 @@ const ProfileDigestLabel = styled('span')`
781781

782782
export default function ProfileSummaryPageToggle() {
783783
return (
784-
<ProfileSummaryContainer data-test-id="profile-summary-redesign">
785-
<ErrorBoundary>
786-
<ProfileSummaryPage />
787-
</ErrorBoundary>
788-
</ProfileSummaryContainer>
784+
<Layout.Page>
785+
<ProfileSummaryContainer data-test-id="profile-summary-redesign">
786+
<ErrorBoundary>
787+
<ProfileSummaryPage />
788+
</ErrorBoundary>
789+
</ProfileSummaryContainer>
790+
</Layout.Page>
789791
);
790792
}

static/app/views/projectInstall/newProject.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
11
import styled from '@emotion/styled';
22

3+
import * as Layout from 'sentry/components/layouts/thirds';
34
import {SentryDocumentTitle} from 'sentry/components/sentryDocumentTitle';
45

56
import {CreateProject} from './createProject';
67

78
function NewProject() {
89
return (
910
<SentryDocumentTitle>
10-
<Container>
11-
<div className="container">
12-
<Content>
13-
<CreateProject />
14-
</Content>
15-
</div>
16-
</Container>
11+
<Layout.Page>
12+
<Container>
13+
<div className="container">
14+
<Content>
15+
<CreateProject />
16+
</Content>
17+
</div>
18+
</Container>
19+
</Layout.Page>
1720
</SentryDocumentTitle>
1821
);
1922
}

0 commit comments

Comments
 (0)