Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add NextJS 15 E2E test app #852

Merged
merged 5 commits into from
Mar 11, 2025
Merged

test(e2e): Add NextJS 15 E2E test app #852

merged 5 commits into from
Mar 11, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 11, 2025

This PR adds a new NextJS 15 e2e test app. The reason is that we want to test against TypeScript-based next.config.ts files (to avoid bugs like #798). This is a NextJS>=15 feature though, so our existing Next 14 can't be adapted. Therefore this PR also supersedes #810.

This PR also renames the existing "NextJS" e2e test app to "NextJS-14", so that we can distinguish the two apps properly in the yarn test:e2e command as well as visually on first glance

#skip-changelog

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.15%. Comparing base (4f49ad8) to head (885082b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #852    +/-   ##
========================================
  Coverage   51.15%   51.15%            
========================================
  Files          53       53            
  Lines        3519     3519            
  Branches      816      827    +11     
========================================
  Hits         1800     1800            
+ Misses       1718     1592   -126     
- Partials        1      127   +126     
Flag Coverage Δ
e2e-tests 80.85% <ø> (ø)
unit-tests 49.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lms24 Lms24 requested review from lforst and andreiborza March 11, 2025 11:07
@Lms24 Lms24 marked this pull request as ready for review March 11, 2025 11:07
@Lms24 Lms24 merged commit bb590bb into master Mar 11, 2025
22 checks passed
@Lms24 Lms24 deleted the lms/test-e2e-next-15 branch March 11, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants