Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Fix nuxt e2e tests #850

Merged
merged 4 commits into from
Mar 11, 2025
Merged

test(e2e): Fix nuxt e2e tests #850

merged 4 commits into from
Mar 11, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 10, 2025

Pinning Nuxt to 3.15.0 for now since 3.16.0 breaks the e2e tests. Root cause: getsentry/sentry-javascript#15628

No strong opinions but once we or Nuxt fix the 3.16.0 issue, we can also revert this PR if we prefer testing with the latest version again.

#skip-changelog

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.15%. Comparing base (c628975) to head (dec8fac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   51.09%   51.15%   +0.05%     
==========================================
  Files          53       53              
  Lines        3519     3519              
  Branches      827      816      -11     
==========================================
+ Hits         1798     1800       +2     
- Misses       1594     1718     +124     
+ Partials      127        1     -126     
Flag Coverage Δ
e2e-tests 80.85% <ø> (+1.41%) ⬆️
unit-tests 49.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lms24 Lms24 changed the title WIP: fix nuxt e2e tests test(e2e): Fix nuxt e2e tests Mar 11, 2025
@Lms24 Lms24 requested a review from andreiborza March 11, 2025 09:46
@Lms24 Lms24 self-assigned this Mar 11, 2025
@Lms24 Lms24 marked this pull request as ready for review March 11, 2025 09:46
@Lms24 Lms24 requested a review from s1gr1d March 11, 2025 09:47
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Lms24 Lms24 merged commit dc398bc into master Mar 11, 2025
22 of 23 checks passed
@Lms24 Lms24 deleted the lms/fix-nuxt-e2e-tests branch March 11, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants