Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): More granular error catching while modifying config #833

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 28, 2025

Adds more try/catches around each step of modifying the Nuxt config. Each step fails by setting appropriate tags and displays an error message in the output.

@s1gr1d s1gr1d requested a review from andreiborza February 28, 2025 12:29
@s1gr1d s1gr1d self-assigned this Feb 28, 2025
@s1gr1d s1gr1d requested a review from smeubank February 28, 2025 12:29
Copy link

github-actions bot commented Feb 28, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 143fa5e

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.83%. Comparing base (e42459a) to head (143fa5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   50.83%   50.83%           
=======================================
  Files          53       53           
  Lines        3517     3517           
  Branches      825      825           
=======================================
  Hits         1788     1788           
  Misses       1601     1601           
  Partials      128      128           
Flag Coverage Δ
e2e-tests 80.85% <ø> (ø)
unit-tests 49.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s1gr1d s1gr1d requested a review from andreiborza February 28, 2025 14:37
@s1gr1d s1gr1d merged commit f89b4f8 into master Feb 28, 2025
19 checks passed
@s1gr1d s1gr1d deleted the sig/nuxt-tags branch February 28, 2025 14:45
@smeubank smeubank linked an issue Mar 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nuxt] Error while setting up the Nuxt Module in nuxt config
2 participants