Fix(Cordova) enhanced node path detection, debug symbols now run in foreground. #694
Conversation
lib/Steps/Integrations/Cordova.ts
Outdated
| @@ -190,31 +190,68 @@ export class Cordova extends BaseIntegration { | |||
| shellPath: '/bin/sh', | |||
| shellScript: | |||
| // eslint-disable-next-line prefer-template | |||
There was a problem hiding this comment.
Can we move this to a shell file that will ship with wizard and then copy the content to create the build phase?
For example lib/Steps/Integrations/Cordova/SentryUploadDebugFiles.sh?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 51.15% 50.92% -0.23%
==========================================
Files 53 53
Lines 3517 3517
Branches 825 826 +1
==========================================
- Hits 1799 1791 -8
- Misses 1591 1599 +8
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const script = fs | ||
| .readFileSync(xcodeSymbolScriptPath, 'utf8') | ||
| .replace(/\\/g, '\\\\') | ||
| .replace(/\n/g, '\\n'); |
There was a problem hiding this comment.
Diff check from the shell script file compared to the same script copy/pasted on the xcode project shows the logic above matches the xcode output.
There was a problem hiding this comment.
I my comment, I thought we would add the file to the wizard, and then copy it to the build phase.
Since we are adding the file in the Cordova SDK. https://github.com/getsentry/sentry-cordova/pull/372/files
Can we simplify the code to just executing the file
sentry-wizard/src/react-native/xcode.ts
Line 189 in fe849fe
| const xcodeSourceScriptPath = path.join( | ||
| process.cwd(), | ||
| 'plugins/sentry-cordova/scripts', | ||
| 'xcode-upload-debug-files.sh', |
There was a problem hiding this comment.
The file was added in getsentry/sentry-cordova#372
This is a refactor on how the Cordova Integration runs, the main changes on the PR are: